Mojom frontend: Compute, validate and populate struct field version info

Mojom frontend: Compute, validate and populate struct field version info

We compute, validate and set the |min_version| field of StructField and the |version_info| array of MojomStruct in mojom_types.mojom.

In a nutshell we process the "MinVersion" attributes and perform the validation that is currently done in pack.py in the backend.

We do not yet compute the actual packing data and so the |offset| and |bit| fields of StructField and the |num_bytes| field of StructVersion are currently always set to 0.

We do not yet consume the data in the backend.
- In computed_data.go we repurposed the function ComputeDataForGenerators. It was originally going to be specifically for struct field packing data but now it is a master function that invokes whatever computations need to be done for each user defined type. (We also renamed it to ComputeFinalData).
For Structs it currently invokes ComputeVersionInfo() and ComputeFieldOffsets().
- Got rid of the invocation of ComputeEnumValueIntegers in parse_driver.go because now that is invoked from ComputeFinalData.
- Added some missing functionality to types.go that was needed.
- In serialization.go we set the min_version, offset, and bit fields of StructField. (For now the latter two are set to 0)
  and we set the version_info field of MojomStruct.
- In user_defined_types.go we implemented ComputeVersionInfo()

BUG=#713
R=azani@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/6f7b1c9b36cc70a5170e87b0bc06ee9633e9f02a

[rudominer, 2016-03-18 00:07:32]

Patchset #1 (id:1) has been deleted

[rudominer, 2016-03-18 00:07:39]

Patchset #1 (id:20001) has been deleted

[rudominer, 2016-03-18 00:13:54]

Description was changed from

==========
Working on ComputeVersionInfo and ComputeFieldOffsets.

BUG=
==========

to

==========
Working on ComputeVersionInfo and ComputeFieldOffsets.

BUG=#713
==========

[rudominer, 2016-03-18 00:24:08]

Description was changed from

==========
Working on ComputeVersionInfo and ComputeFieldOffsets.

BUG=#713
==========

to

==========
Mojom frontend: Compute, validate and populate struct field version info

We compute, validate and set the |min_version| field of StructField and the
|version_info| array of MojomStruct in mojom_types.mojom.

In a nutshell we process the "MinVersion" attributes and perform the validation
that is currently done in pack.py in the backend.

We do not yet compute the actual packing data and so the |offset| and |bit|
fields of StructField and the |num_bytes| field of StructVersion are currently
always set to 0.

We do not yet consume the data in the backend.

Miscellaneous:
- Added some missing functionality to types.go that was needed.

BUG=#713
==========

[rudominer, 2016-03-18 00:42:49]

Description was changed from

==========
Mojom frontend: Compute, validate and populate struct field version info

We compute, validate and set the |min_version| field of StructField and the
|version_info| array of MojomStruct in mojom_types.mojom.

In a nutshell we process the "MinVersion" attributes and perform the validation
that is currently done in pack.py in the backend.

We do not yet compute the actual packing data and so the |offset| and |bit|
fields of StructField and the |num_bytes| field of StructVersion are currently
always set to 0.

We do not yet consume the data in the backend.

Miscellaneous:
- Added some missing functionality to types.go that was needed.

BUG=#713
==========

to

==========
Mojom frontend: Compute, validate and populate struct field version info

We compute, validate and set the |min_version| field of StructField and the
|version_info| array of MojomStruct in mojom_types.mojom.

In a nutshell we process the "MinVersion" attributes and perform the validation
that is currently done in pack.py in the backend.

We do not yet compute the actual packing data and so the |offset| and |bit|
fields of StructField and the |num_bytes| field of StructVersion are currently
always set to 0.

We do not yet consume the data in the backend.
- In computed_data.go we repurposed the function ComputeDataForGenerators. It
was originally going to be specifically for struct field packing data but now it
is a master function that invokes whatever computations need to be done for each
user defined type. For Structs it currently invokes ComputeVersionInfo() and
ComputeFieldOffsets().
- Got rid of the invocation of ComputeEnumValueIntegers in parse_driver.go
because now that is invoked from ComputeDataForGenerators.
- Added some missing functionality to types.go that was needed.
- In serialization.go we set the min_version, offset, and bit fields of
StructField. (For now the latter two are set to 0)
  and we set the version_info field of MojomStruct.
- In user_defined_types.go we implemented ComputeVersionInfo()

BUG=#713
==========

[rudominer, 2016-03-18 00:44:09]

rudominer@chromium.org changed reviewers:
+ azani@chromium.org

[rudominer, 2016-03-18 00:44:10]

Hi Alex, ptal.

[azani, 2016-03-18 01:05:52]

https://codereview.chromium.org/1805743003/diff/60001/mojom/mojom_parser/mojo...
File mojom/mojom_parser/mojom/computed_data.go (right):

https://codereview.chromium.org/1805743003/diff/60001/mojom/mojom_parser/mojo...
mojom/mojom_parser/mojom/computed_data.go:23: func (e *MojomEnum)
ComputeDataForGenerators() error {
How about ComputeSerializationData or something like that?

[rudominer, 2016-03-18 01:27:50]

Description was changed from

==========
Mojom frontend: Compute, validate and populate struct field version info

We compute, validate and set the |min_version| field of StructField and the
|version_info| array of MojomStruct in mojom_types.mojom.

In a nutshell we process the "MinVersion" attributes and perform the validation
that is currently done in pack.py in the backend.

We do not yet compute the actual packing data and so the |offset| and |bit|
fields of StructField and the |num_bytes| field of StructVersion are currently
always set to 0.

We do not yet consume the data in the backend.
- In computed_data.go we repurposed the function ComputeDataForGenerators. It
was originally going to be specifically for struct field packing data but now it
is a master function that invokes whatever computations need to be done for each
user defined type. For Structs it currently invokes ComputeVersionInfo() and
ComputeFieldOffsets().
- Got rid of the invocation of ComputeEnumValueIntegers in parse_driver.go
because now that is invoked from ComputeDataForGenerators.
- Added some missing functionality to types.go that was needed.
- In serialization.go we set the min_version, offset, and bit fields of
StructField. (For now the latter two are set to 0)
  and we set the version_info field of MojomStruct.
- In user_defined_types.go we implemented ComputeVersionInfo()

BUG=#713
==========

to

==========
Mojom frontend: Compute, validate and populate struct field version info

We compute, validate and set the |min_version| field of StructField and the
|version_info| array of MojomStruct in mojom_types.mojom.

In a nutshell we process the "MinVersion" attributes and perform the validation
that is currently done in pack.py in the backend.

We do not yet compute the actual packing data and so the |offset| and |bit|
fields of StructField and the |num_bytes| field of StructVersion are currently
always set to 0.

We do not yet consume the data in the backend.
- In computed_data.go we repurposed the function ComputeDataForGenerators. It
was originally going to be specifically for struct field packing data but now it
is a master function that invokes whatever computations need to be done for each
user defined type. (We also renamed it to ComputeFinalData).
For Structs it currently invokes ComputeVersionInfo() and ComputeFieldOffsets().
- Got rid of the invocation of ComputeEnumValueIntegers in parse_driver.go
because now that is invoked from ComputeFinalData.
- Added some missing functionality to types.go that was needed.
- In serialization.go we set the min_version, offset, and bit fields of
StructField. (For now the latter two are set to 0)
  and we set the version_info field of MojomStruct.
- In user_defined_types.go we implemented ComputeVersionInfo()

BUG=#713
==========

[rudominer, 2016-03-18 01:28:30]

ptal

https://codereview.chromium.org/1805743003/diff/60001/mojom/mojom_parser/mojo...
File mojom/mojom_parser/mojom/computed_data.go (right):

https://codereview.chromium.org/1805743003/diff/60001/mojom/mojom_parser/mojo...
mojom/mojom_parser/mojom/computed_data.go:23: func (e *MojomEnum)
ComputeDataForGenerators() error {
On 2016/03/18 01:05:52, azani wrote:
> How about ComputeSerializationData or something like that?

I changed it to ComputeFinalData.

[azani, 2016-03-18 18:20:53]

lgtm

[rudominer, 2016-03-18 18:40:39]

Description was changed from

==========
Mojom frontend: Compute, validate and populate struct field version info

We compute, validate and set the |min_version| field of StructField and the
|version_info| array of MojomStruct in mojom_types.mojom.

In a nutshell we process the "MinVersion" attributes and perform the validation
that is currently done in pack.py in the backend.

We do not yet compute the actual packing data and so the |offset| and |bit|
fields of StructField and the |num_bytes| field of StructVersion are currently
always set to 0.

We do not yet consume the data in the backend.
- In computed_data.go we repurposed the function ComputeDataForGenerators. It
was originally going to be specifically for struct field packing data but now it
is a master function that invokes whatever computations need to be done for each
user defined type. (We also renamed it to ComputeFinalData).
For Structs it currently invokes ComputeVersionInfo() and ComputeFieldOffsets().
- Got rid of the invocation of ComputeEnumValueIntegers in parse_driver.go
because now that is invoked from ComputeFinalData.
- Added some missing functionality to types.go that was needed.
- In serialization.go we set the min_version, offset, and bit fields of
StructField. (For now the latter two are set to 0)
  and we set the version_info field of MojomStruct.
- In user_defined_types.go we implemented ComputeVersionInfo()

BUG=#713
==========

to

==========
Mojom frontend: Compute, validate and populate struct field version info

We compute, validate and set the |min_version| field of StructField and the
|version_info| array of MojomStruct in mojom_types.mojom.

In a nutshell we process the "MinVersion" attributes and perform the validation
that is currently done in pack.py in the backend.

We do not yet compute the actual packing data and so the |offset| and |bit|
fields of StructField and the |num_bytes| field of StructVersion are currently
always set to 0.

We do not yet consume the data in the backend.
- In computed_data.go we repurposed the function ComputeDataForGenerators. It
was originally going to be specifically for struct field packing data but now it
is a master function that invokes whatever computations need to be done for each
user defined type. (We also renamed it to ComputeFinalData).
For Structs it currently invokes ComputeVersionInfo() and ComputeFieldOffsets().
- Got rid of the invocation of ComputeEnumValueIntegers in parse_driver.go
because now that is invoked from ComputeFinalData.
- Added some missing functionality to types.go that was needed.
- In serialization.go we set the min_version, offset, and bit fields of
StructField. (For now the latter two are set to 0)
  and we set the version_info field of MojomStruct.
- In user_defined_types.go we implemented ComputeVersionInfo()

BUG=#713
R=azani@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/6f7b1c9b36cc70a5170e87b0bc0...
==========

[rudominer, 2016-03-18 18:40:42]

Committed patchset #3 (id:80001) manually as
6f7b1c9b36cc70a5170e87b0bc06ee9633e9f02a (presubmit successful).