Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1805743002: [DevTools] Do not detach view just to reattach it again in SplitWidget. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not detach view just to reattach it again in SplitWidget. BUG=594531 Committed: https://crrev.com/410d08c7d1d29e24d5385d7ac2e433d19763eb68 Cr-Commit-Position: refs/heads/master@{#381374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 9 months ago (2016-03-15 23:39:54 UTC) #2
caseq
lgtm
4 years, 9 months ago (2016-03-15 23:41:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805743002/1
4 years, 9 months ago (2016-03-15 23:42:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 01:03:00 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 01:08:06 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/410d08c7d1d29e24d5385d7ac2e433d19763eb68
Cr-Commit-Position: refs/heads/master@{#381374}

Powered by Google App Engine
This is Rietveld 408576698