Issue 180573003: Revert of Handle SSL timeouts in Rietveld requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180573003: Revert of Handle SSL timeouts in Rietveld requests. (Closed)

Created:
6 years, 9 months ago by Sergey Berezin

Modified:
6 years, 9 months ago

Reviewers:
M-A Ruel, ghost stip (do not use)

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

Revert of Handle SSL timeouts in Rietveld requests. (https://codereview.chromium.org/180273003/) Reason for revert: SSLError does not have a field 'reason'. Reverting this, and I'll create another, correct patch after actually testing it properly. Sorry. Original issue's description: > Handle SSL timeouts in Rietveld requests. > > BUG=346845 > R=maruel@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=253271 TBR=maruel@chromium.org NOTREECHECKS=true NOTRY=true BUG=346845

Created: 6 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	rietveld.py	View		2 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 6 (0 generated)

Sergey Berezin

Created Revert of Handle SSL timeouts in Rietveld requests.

6 years, 9 months ago (2014-02-25 23:43:15 UTC) #1

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-02-25 23:56:59 UTC) #2

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

6 years, 9 months ago (2014-02-25 23:57:00 UTC) #3

Sergey Berezin

Can't revert without an LGTM... Could you stamp it please? Thanks!

6 years, 9 months ago (2014-02-26 00:10:11 UTC) #4

Sergey Berezin

6 years, 9 months ago (2014-02-26 00:31:16 UTC) #6

Never mind, I'll just submit a fix instead of the revert. Fewer commits. Sorry
for the spam :-)