Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1805723002: Reland: H264 HW encode using VideoToolbox (Closed)

Created:
4 years, 9 months ago by emircan
Modified:
4 years, 9 months ago
Reviewers:
mcasas, dewittj
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, imcheng+watch_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: H264 HW encode using VideoToolbox Reland CL: https://codereview.chromium.org/1636083003/ This CL adds VTVideoEncodeAccelerator which enables H264 encode support using VideoToolbox on mac. Also, it includes a refactor of common VideoToolbox classes under video_toolbox_helpers.*. Note that, this is the first CL and H264 codec is still behind a flag. More patches will follow adding additional codec profiles and support for bitrate adaptations. Design Doc: https://docs.google.com/document/d/1oUTyZdNh8QstKRds-8wHEF_hqKryMiUpEOW8M57sUGU/edit?usp=sharing BUG=500605 TEST= Tested AppRTC loopback with Chrome flag "--enable-webrtc-hw-h264-encoding" on https://apprtc.appspot.com/?debug=loopback&vsc=h264 TBR=avi@chromium.org, jfroy@chromium.org, sandersd@chromium.org, thakis@chromium.org, posciak@chromium.org, miu@chromium.org Committed: https://crrev.com/ecfe5eced92b99fb8dc2351cd2afd533c2bfb953 Cr-Commit-Position: refs/heads/master@{#381373}

Patch Set 1 #

Patch Set 2 : Fix gyp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+849 lines, -1615 lines) Patch
M build/gn_migration.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/cast_streaming/end_to_end_sender.js View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 7 chunks +38 lines, -1 line 0 comments Download
A + content/common/gpu/media/vt_video_encode_accelerator_mac.h View 2 chunks +104 lines, -97 lines 0 comments Download
A + content/common/gpu/media/vt_video_encode_accelerator_mac.cc View 1 chunk +439 lines, -656 lines 0 comments Download
M content/content_common.gypi View 3 chunks +5 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +7 lines, -2 lines 0 comments Download
M media/base/mac/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/mac/videotoolbox_glue.h View 3 chunks +10 lines, -5 lines 0 comments Download
M media/base/mac/videotoolbox_glue.mm View 6 chunks +9 lines, -0 lines 0 comments Download
A + media/base/mac/videotoolbox_helpers.h View 1 chunk +52 lines, -45 lines 0 comments Download
A + media/base/mac/videotoolbox_helpers.cc View 9 chunks +125 lines, -590 lines 0 comments Download
M media/cast/sender/h264_vt_encoder.h View 2 chunks +1 line, -5 lines 0 comments Download
M media/cast/sender/h264_vt_encoder.cc View 8 chunks +28 lines, -209 lines 0 comments Download
M media/cast/sender/video_encoder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/media.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
emircan
PS#2 includes the fix. PTAL.
4 years, 9 months ago (2016-03-15 23:09:55 UTC) #4
mcasas
lgtm
4 years, 9 months ago (2016-03-15 23:13:26 UTC) #5
dewittj
gypi lgtm, thanks
4 years, 9 months ago (2016-03-15 23:18:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805723002/20001
4 years, 9 months ago (2016-03-16 00:56:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 01:02:32 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ecfe5eced92b99fb8dc2351cd2afd533c2bfb953 Cr-Commit-Position: refs/heads/master@{#381373}
4 years, 9 months ago (2016-03-16 01:03:48 UTC) #13
emircan
4 years, 9 months ago (2016-03-16 02:31:55 UTC) #14
Message was sent while issue was closed.
Note that CL passed the Mac gyp bot:
https://build.chromium.org/p/chromium/builders/Mac/builds/13220

Powered by Google App Engine
This is Rietveld 408576698