Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1805683003: disable assembly in header for msan=1 (Closed)

Created:
4 years, 9 months ago by fbarchard1
Modified:
4 years, 9 months ago
Reviewers:
impjdi, wtc1
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

disable assembly in header for msan=1 GYP_DEFINES="target_arch=x64 msan=1" ./gyp_libyuv ninja -j7 -C out/Release R=impjdi@google.com BUG=libyuv:575 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/837aa1e2af6c3e7c9e1d6bc240052139c71d2b38

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/compare_row.h View 1 chunk +6 lines, -0 lines 1 comment Download
M include/libyuv/planar_functions.h View 1 chunk +6 lines, -0 lines 0 comments Download
M include/libyuv/rotate_row.h View 1 chunk +6 lines, -1 line 0 comments Download
M include/libyuv/row.h View 1 chunk +6 lines, -0 lines 0 comments Download
M include/libyuv/scale_row.h View 1 chunk +6 lines, -0 lines 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M libyuv.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
M libyuv_test.gyp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fbarchard1
4 years, 9 months ago (2016-03-16 00:01:31 UTC) #1
impjdi
lgtm Thanks for preparing this! I really appreciate this! :D
4 years, 9 months ago (2016-03-16 00:08:39 UTC) #2
fbarchard1
Committed patchset #1 (id:1) manually as 837aa1e2af6c3e7c9e1d6bc240052139c71d2b38 (presubmit successful).
4 years, 9 months ago (2016-03-16 01:45:42 UTC) #4
wtc1
4 years, 9 months ago (2016-03-16 17:24:55 UTC) #6
Message was sent while issue was closed.
LGTM. Thanks.

I verified you modified all the headers that test LIBYUV_DISABLE_X86.

https://codereview.chromium.org/1805683003/diff/1/include/libyuv/compare_row.h
File include/libyuv/compare_row.h (right):

https://codereview.chromium.org/1805683003/diff/1/include/libyuv/compare_row....
include/libyuv/compare_row.h:25: // MemorySanitizer does not support assembly
code yet. http://crbug.com/344505

Frank: do you know whether it's just inline assembly code in C/C++ files or all
assembly code (including the assembly code in .s/.S files) that MemorySanitizer
doesn't support?

Powered by Google App Engine
This is Rietveld 408576698