Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Unified Diff: base/BUILD.gn

Issue 1805643002: 🚀 Geneate base_unittest's Android .isolate file at build-time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/gyp/gen-android-test-isolate.py » ('j') | testing/test.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index cfe258bae5d2e56972efc4e78f3f57cb6e46eb18..b317ceb0c79a889e8740f0c93f7fa4293764a9e9 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1884,6 +1884,7 @@ test("base_unittests") {
# Some unittests depend on the ALLOCATOR_SHIM macro.
configs += [ "//base/allocator:allocator_shim_define" ]
+ requires_apk_isolate = is_android
data = [
"test/data/",
]
@@ -1900,10 +1901,6 @@ test("base_unittests") {
":base_java_unittest_support",
"//base/android/jni_generator:jni_generator_tests",
]
-
- # TODO(brettw) I think this should not be here, we should not be using
- # isolate files.
- isolate_file = "base_unittests.isolate"
}
if (is_ios) {
« no previous file with comments | « no previous file | build/android/gyp/gen-android-test-isolate.py » ('j') | testing/test.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698