Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1805613002: Make ElementLocationImpl.hashCode SMI, improve performance. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make ElementLocationImpl.hashCode SMI, improve performance. This makes Analyzer + Analysis Server analysis 6% faster. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/99517a162cbabf3d3afbdb566df3fe2b18cd4877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-15 18:27:04 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-15 18:31:03 UTC) #2
scheglov
4 years, 9 months ago (2016-03-15 18:52:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
99517a162cbabf3d3afbdb566df3fe2b18cd4877 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698