Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1805593002: Subzero: Shorten global prefixes in non-DUMP build. (Closed)

Created:
4 years, 9 months ago by Jim Stichnoth
Modified:
4 years, 9 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Shorten global prefixes in non-DUMP build. Reverts part of 843142fe (https://codereview.chromium.org/1776343004). Makes global prefixes short in all non-DUMP builds, not just the browser build, so that the user doesn't need to remember to supply the override options in a command-line MINIMAL build. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3b4dc93e87a2f6bff7be6f8f0fa1efc4dd19ae66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M src/IceBrowserCompileServer.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/IceClFlags.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 9 months ago (2016-03-15 17:57:33 UTC) #3
John
lgtm
4 years, 9 months ago (2016-03-15 18:08:13 UTC) #4
Jim Stichnoth
4 years, 9 months ago (2016-03-15 18:09:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b4dc93e87a2f6bff7be6f8f0fa1efc4dd19ae66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698