For Desktop tab sharing, activate selected inactive tab

chrome/browser/ui/views/desktop_media_picker_views.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/desktop_media_picker_views.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/media/desktop_media_list.h"
 #include "chrome/browser/ui/ash/ash_util.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/constrained_window/constrained_window_views.h"
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "grit/components_strings.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/events/event_constants.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 #include "ui/gfx/canvas.h"
 #include "ui/native_theme/native_theme.h"
 #include "ui/views/background.h"
 #include "ui/views/bubble/bubble_frame_view.h"
@@ skipping 476 matching lines @@
     ui::DialogButton button) const {
   return l10n_util::GetStringUTF16(button == ui::DIALOG_BUTTON_OK ?
       IDS_DESKTOP_MEDIA_PICKER_SHARE : IDS_CANCEL);
 }
 
 bool DesktopMediaPickerDialogView::Accept() {
   DesktopMediaSourceView* selection = sources_list_view_->GetSelection();
 
   // Ok button should only be enabled when a source is selected.
   DCHECK(selection);
-
-  DesktopMediaID source;
-  if (selection)
-    source = selection->source_id();
-
+  DesktopMediaID source = selection->source_id();
   source.audio_share = audio_share_checkbox_ &&
                        audio_share_checkbox_->enabled() &&
                        audio_share_checkbox_->checked();
 
+  // If the media source is an inactive tab, activate it.
+  if (source.type == DesktopMediaID::TYPE_WEB_CONTENTS) {
+    content::WebContents* tab = content::WebContents::FromRenderFrameHost(
+        content::RenderFrameHost::FromID(
+            source.web_contents_id.render_process_id,
+            source.web_contents_id.main_render_frame_id));
+    if (tab) {
+      Browser* browser = chrome::FindBrowserWithWebContents(tab);
+      if (browser) {

[msw, 2016/03/15 23:58:19]

When would browser be null? Do we need to check this?

[GeorgeZ, 2016/03/16 00:32:32]

You are right, as long as tab is valid, browser should be valid.

+        TabStripModel* tab_strip_model = browser->tab_strip_model();
+        DCHECK(tab_strip_model);

[msw, 2016/03/15 23:58:19]

nit: dcheck before dereference is unnecessary.

[GeorgeZ, 2016/03/16 00:32:32]

Done.

+
+        const int tab_index = tab_strip_model->GetIndexOfWebContents(tab);
+        if (tab_index != tab_strip_model->active_index())

[msw, 2016/03/15 23:58:19]

Must we check if the tab is inactive? Otherwise, this whole block becomes:
  tab->GetDelegate()->ActivateContents(tab);
If necessary, use 'tab != browser->tab_strip_model()->GetActiveWebContents()'

[GeorgeZ, 2016/03/16 00:32:32]

A check probably is not necessary.

+          tab->GetDelegate()->ActivateContents(tab);
+      }
+    }
+  }
+
   if (parent_)
     parent_->NotifyDialogResult(source);
 
   // Return true to close the window.
   return true;
 }
 
 void DesktopMediaPickerDialogView::DeleteDelegate() {
   // If the dialog is being closed then notify the parent about it.
   if (parent_)
@@ skipping 90 matching lines @@
   content::BrowserThread::PostTask(
       content::BrowserThread::UI, FROM_HERE,
       base::Bind(callback_, source));
   callback_.Reset();
 }
 
 // static
 scoped_ptr<DesktopMediaPicker> DesktopMediaPicker::Create() {
   return scoped_ptr<DesktopMediaPicker>(new DesktopMediaPickerViews());
 }