Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1805563002: Revert "Delete support for source mirrors" (Closed)

Created:
4 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 9 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Delete support for source mirrors" This reverts commit 6586b3696eae6f750644273ece5cb68dc3d304a5. Bots broke because of some references I didn't notice before. BUG= Committed: https://github.com/dart-lang/sdk/commit/fa35ff3837cf9e139e5ed6399d3ed126438f2347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5124 lines, -0 lines) Patch
A pkg/compiler/lib/src/mirrors/analyze.dart View 1 chunk +75 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart View 1 chunk +298 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/mirrors/dart2js_library_mirror.dart View 1 chunk +257 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart View 1 chunk +239 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 chunk +490 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/mirrors/dart2js_type_mirrors.dart View 1 chunk +510 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/mirrors/mirrors_util.dart View 1 chunk +429 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/mirrors/source_mirrors.dart View 1 chunk +255 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/analyze_test_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 2 chunks +22 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirror_system_helper.dart View 1 chunk +139 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/class_mirror_type_variables_test.dart View 1 chunk +42 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/default_value_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/field_parameter_type_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/library_exports_hidden_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/library_exports_shown_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/library_imports_hidden_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/library_imports_prefixed_show_hide_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/library_imports_prefixed_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/library_imports_shown_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/mirrors_reader_test.dart View 1 chunk +142 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/mirrors_test_helper.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/relation_assignable_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/relation_subclass_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors/relation_subtype_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors_exports_test.dart View 1 chunk +183 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors_helper.dart View 1 chunk +78 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors_lookup_test.dart View 1 chunk +263 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors_metadata_test.dart View 1 chunk +86 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors_mixin_test.dart View 1 chunk +240 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/mirrors_test.dart View 1 chunk +974 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/strip_comment_test.dart View 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as fa35ff3837cf9e139e5ed6399d3ed126438f2347 (presubmit successful).
4 years, 9 months ago (2016-03-15 16:13:59 UTC) #2
Siggi Cherem (dart-lang)
TBR
4 years, 9 months ago (2016-03-15 16:14:39 UTC) #4
Johnni Winther
4 years, 9 months ago (2016-03-16 08:13:07 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698