Directory support for the analyzer CLI (#25129).

Directory support for the analyzer CLI (#25129).

Adds smarts to recurse through directories to assemble a list of dart files to analyze.

Addresses: https://github.com/dart-lang/sdk/issues/25129

Do note that all of these files are sharing the same analysis context (and options).  Once the the ContextManager re-work is complete this can get smarter (see: https://github.com/dart-lang/sdk/issues/24133).

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/0bd85a2435481bad3f4c862319059e93c16eb41d

[pquitslund, 2016-03-16 20:33:58]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2016-03-16 20:42:52]

LGTM

https://codereview.chromium.org/1805533005/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/1805533005/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:561: path.split(relative).any((part) =>
part.startsWith("."));
Does this need to worry about having ".." as a part? (The word "relative"
suggests that it might.)

[scheglov, 2016-03-16 20:43:32]

LGTM

[pquitslund, 2016-03-16 20:55:42]

Thanks!

https://codereview.chromium.org/1805533005/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/1805533005/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:561: path.split(relative).any((part) =>
part.startsWith("."));
On 2016/03/16 20:42:52, Brian Wilkerson wrote:
> Does this need to worry about having ".." as a part? (The word "relative"
> suggests that it might.)

Good eye.  In general maybe, but I think we're safe in this case since all of
the paths are coming from the directory listing and we should always be
recursing down and never up.

[pquitslund, 2016-03-16 20:56:18]

Description was changed from

==========
Directory support for the analyzer CLI (#25129).

Adds smarts to recurse through directories to assemble a list of dart files to
analyze.

Addresses: https://github.com/dart-lang/sdk/issues/25129

Do note that all of these files are sharing the same analysis context (and
options).  Once the the ContextManager re-work is complete this can get smarter
(see: https://github.com/dart-lang/sdk/issues/24133).

BUG=
==========

to

==========
Directory support for the analyzer CLI (#25129).

Adds smarts to recurse through directories to assemble a list of dart files to
analyze.

Addresses: https://github.com/dart-lang/sdk/issues/25129

Do note that all of these files are sharing the same analysis context (and
options).  Once the the ContextManager re-work is complete this can get smarter
(see: https://github.com/dart-lang/sdk/issues/24133).

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0bd85a2435481bad3f4c862319059e93c16eb41d
==========

[pquitslund, 2016-03-16 20:56:20]

Committed patchset #1 (id:1) manually as
0bd85a2435481bad3f4c862319059e93c16eb41d (presubmit successful).