Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1805533004: [Media Router WebUI] Uniform height for initial spinner and "Device missing?" views. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Uniform height for initial spinner and "Device missing?" views. The spinner is takes up more height than the "Device missing?" text, so there's some seemingly janky behavior with the dialog a few seconds after the dialog is opened if there are no devices found. This change ensures the dialog doesn't resize immediately after opening when transitioning to showing "Device missing?". BUG=595021 Committed: https://crrev.com/da9d9f67121aa1dd94c55b2a75a334a4d324175e Cr-Commit-Position: refs/heads/master@{#381825}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
apacible
PTAL, thanks! Spinner: https://screenshot.googleplex.com/aShmybVHbQq.png Device missing?: https://screenshot.googleplex.com/6QruPkE8fcU.png
4 years, 9 months ago (2016-03-16 00:16:14 UTC) #4
imcheng
lgtm
4 years, 9 months ago (2016-03-17 18:42:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805533004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805533004/20001
4 years, 9 months ago (2016-03-17 22:09:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 23:06:51 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 23:08:14 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da9d9f67121aa1dd94c55b2a75a334a4d324175e
Cr-Commit-Position: refs/heads/master@{#381825}

Powered by Google App Engine
This is Rietveld 408576698