S390: Initial test changes and files checkin.

S390: Initial test changes and files checkin.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com
BUG=

Committed: https://crrev.com/3b5e84ab0ea9cfa75e2ee7762a284bdbdfd8bad6
Cr-Commit-Position: refs/heads/master@{#34795}

[john.yan, 2016-03-15 14:31:08]

Patchset #1 (id:1) has been deleted

[john.yan, 2016-03-15 14:39:23]

Patchset #1 (id:20001) has been deleted

[john.yan, 2016-03-15 14:39:38]

S390: Initial test changes and files checkin.

[john.yan, 2016-03-15 14:39:54]

The CQ bit was checked by jyan@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-15 14:40:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805533002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805533002/40001

[commit-bot: I haz the power, 2016-03-15 14:44:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-15 14:44:30]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/15373)

[Jakob Kummerow, 2016-03-15 14:58:04]

Status file conditions aren't magic, you'll have to add "s390" and "s390x" to
the VARIABLES list in tools/testrunner/local/statusfile.py (around line 60).

https://codereview.chromium.org/1805533002/diff/40001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-crbug-178790.js (right):

https://codereview.chromium.org/1805533002/diff/40001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-crbug-178790.js:33: // Flags: --stack-size=8192
This is a lot, considering that the default value is 984K, and on Windows a
process will get killed when it uses more than 1024K.

Have you tested this on all platforms and operating systems? What's special
about this test's stack consumption? What happens when you don't set the extra
flag? Would it make sense to set an s390 specific V8_DEFAULT_STACK_SIZE_KB value
in globals.h instead?

[john.yan, 2016-03-15 15:00:15]

The CQ bit was checked by jyan@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-15 15:00:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805533002/60001

[commit-bot: I haz the power, 2016-03-15 15:31:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-15 15:31:36]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/4393)
  v8_win_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[john.yan, 2016-03-15 16:45:49]

On 2016/03/15 14:58:04, Jakob wrote:
> Status file conditions aren't magic, you'll have to add "s390" and "s390x" to
> the VARIABLES list in tools/testrunner/local/statusfile.py (around line 60).
> 
>
https://codereview.chromium.org/1805533002/diff/40001/test/mjsunit/regress/re...
> File test/mjsunit/regress/regress-crbug-178790.js (right):
> 
>
https://codereview.chromium.org/1805533002/diff/40001/test/mjsunit/regress/re...
> test/mjsunit/regress/regress-crbug-178790.js:33: // Flags: --stack-size=8192
> This is a lot, considering that the default value is 984K, and on Windows a
> process will get killed when it uses more than 1024K.
> 
> Have you tested this on all platforms and operating systems? What's special
> about this test's stack consumption? What happens when you don't set the extra
> flag? Would it make sense to set an s390 specific V8_DEFAULT_STACK_SIZE_KB
value
> in globals.h instead?

Hello Jakob, yes, we have tested this on 64-bit Linux platform on S390X. On
S390X, each native call frame requires at least 160 bytes of stack space, which
is much memory hunger than most platform including Intel. In this specific test,
because of recursion, thousands of call frames can be observed when test is
failing. And increasing the stack would solve the issue. However, I would remove
this for now because windows is failing.

[john.yan, 2016-03-15 16:58:59]

The CQ bit was checked by jyan@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-15 16:59:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805533002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805533002/100001

[Jakob Kummerow, 2016-03-15 17:19:13]

On 2016/03/15 16:45:49, john.yan wrote:
> On S390X, each native call frame requires at least 160 bytes of stack space,
> which is much memory hunger than most platform including Intel.

Sounds like setting a larger V8_DEFAULT_STACK_SIZE_KB might be reasonable then
(in another CL).

Patch set 4 LGTM.

[commit-bot: I haz the power, 2016-03-15 17:20:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-15 17:20:02]

Dry run: This issue passed the CQ dry run.

[john.yan, 2016-03-15 18:01:37]

The CQ bit was unchecked by jyan@ca.ibm.com

[john.yan, 2016-03-15 18:01:47]

The CQ bit was checked by jyan@ca.ibm.com

[commit-bot: I haz the power, 2016-03-15 18:01:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805533002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805533002/100001

[commit-bot: I haz the power, 2016-03-15 18:07:47]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-03-15 18:09:43]

Description was changed from

==========
S390: Initial test changes and files checkin.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,joransiu@ca.i...
BUG=
==========

to

==========
S390: Initial test changes and files checkin.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,joransiu@ca.i...
BUG=

Committed: https://crrev.com/3b5e84ab0ea9cfa75e2ee7762a284bdbdfd8bad6
Cr-Commit-Position: refs/heads/master@{#34795}
==========

[commit-bot: I haz the power, 2016-03-15 18:09:44]

Patchset 4 (id:??) landed as
https://crrev.com/3b5e84ab0ea9cfa75e2ee7762a284bdbdfd8bad6
Cr-Commit-Position: refs/heads/master@{#34795}