Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1805503003: [Interpreter] Add bytecode generator expectations for super calls. (Closed)

Created:
4 years, 9 months ago by rmcilroy
Modified:
4 years, 9 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add bytecode generator expectations for super calls. BUG=v8:4682 LOG=N Committed: https://crrev.com/18109232c1cddfa8b076dc8901fc02d983a1f0a7 Cr-Commit-Position: refs/heads/master@{#34819}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add additional test cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -6 lines) Patch
A test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden View 1 1 chunk +261 lines, -0 lines 0 comments Download
M test/cctest/interpreter/generate-bytecode-expectations.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 2 chunks +58 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805503003/1
4 years, 9 months ago (2016-03-15 14:07:40 UTC) #2
rmcilroy
PTAL, thanks.
4 years, 9 months ago (2016-03-15 14:07:44 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 14:27:32 UTC) #6
oth
lgtm with minor comments. A few more easy cases would be good - mjsunit has ...
4 years, 9 months ago (2016-03-15 14:54:09 UTC) #7
rmcilroy
https://codereview.chromium.org/1805503003/diff/1/test/cctest/interpreter/test-bytecode-generator.cc File test/cctest/interpreter/test-bytecode-generator.cc (right): https://codereview.chromium.org/1805503003/diff/1/test/cctest/interpreter/test-bytecode-generator.cc#newcode2140 test/cctest/interpreter/test-bytecode-generator.cc:2140: const char* snippets[] = { On 2016/03/15 14:54:09, oth ...
4 years, 9 months ago (2016-03-16 14:16:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805503003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805503003/20001
4 years, 9 months ago (2016-03-16 14:17:06 UTC) #11
oth
Cool, lgtm, thanks.
4 years, 9 months ago (2016-03-16 14:25:12 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 14:41:13 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 14:43:05 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/18109232c1cddfa8b076dc8901fc02d983a1f0a7
Cr-Commit-Position: refs/heads/master@{#34819}

Powered by Google App Engine
This is Rietveld 408576698