Issue 18055014: Fixes for nacl_debugger's use of picture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18055014: Fixes for nacl_debugger's use of picture. (Closed)

Created:
7 years, 5 months ago by scroggo

Modified:
7 years, 5 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fixes for nacl_debugger's use of picture. Now that CreateFromStream is used, check for NULL rather than looking at width and height (prevents a crash on an invalid SKP). Unref the picture when done with it. Remove the member variable for picture, since it is only accessed inside the one function. R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=9831

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	platform_tools/nacl/src/nacl_debugger.cpp	View		3 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scroggo

I noticed when I wrote https://code.google.com/p/skia/source/detail?r=9824 that the picture is leaked, and I introduced a ...

7 years, 5 months ago (2013-06-28 22:39:05 UTC) #1

scroggo

7 years, 5 months ago (2013-07-01 12:42:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r9831 (presubmit successful).

Expand Messages | Collapse Messages