Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 18055009: Minimal changes for SampleApp to be HiDPI aware on Mac. (Closed)

Created:
7 years, 5 months ago by bungeman-skia
Modified:
7 years, 5 months ago
Reviewers:
caryclark
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Minimal changes for SampleApp to eb HiDPI aware on Mac. R=caryclark@google.com Committed: https://code.google.com/p/skia/source/detail?r=9807

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -4 lines) Patch
M src/views/mac/SampleApp-Info.plist View 1 chunk +2 lines, -0 lines 0 comments Download
M src/views/mac/SkNSView.mm View 1 8 chunks +74 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-skia
Note that this doesn't attempt to scale anything or even provide notifications to the app ...
7 years, 5 months ago (2013-06-28 16:30:10 UTC) #1
bungeman-skia
At Patch Set 2 now comes with braces and shorter lines.
7 years, 5 months ago (2013-06-28 16:40:40 UTC) #2
caryclark
lgtm
7 years, 5 months ago (2013-06-28 16:42:28 UTC) #3
bungeman-skia
7 years, 5 months ago (2013-06-28 16:44:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r9807 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698