Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: chrome/common/chrome_content_client.cc

Issue 18055008: Expose "Chrome" as accessible product name. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Parse product name in b_a_win.cc instead Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/chrome_content_client.cc
diff --git a/chrome/common/chrome_content_client.cc b/chrome/common/chrome_content_client.cc
index d68448774851538a7ddb080a6127c7da413ea07e..d0d178f6c4ad642dee57dacedb2d2f4046659601 100644
--- a/chrome/common/chrome_content_client.cc
+++ b/chrome/common/chrome_content_client.cc
@@ -387,13 +387,6 @@ bool GetBundledPepperFlash(content::PepperPluginInfo* plugin) {
namespace chrome {
-std::string ChromeContentClient::GetProductImpl() {
- chrome::VersionInfo version_info;
- std::string product("Chrome/");
- product += version_info.is_valid() ? version_info.Version() : "0.0.0.0";
- return product;
-}
-
void ChromeContentClient::SetActiveURL(const GURL& url) {
child_process_logging::SetActiveURL(url);
}
@@ -439,7 +432,9 @@ bool ChromeContentClient::CanHandleWhileSwappedOut(
}
std::string ChromeContentClient::GetProduct() const {
- return GetProductImpl();
+ chrome::VersionInfo version_info;
+ return version_info.is_valid() ?
+ version_info.ProductNameAndVersionForUserAgent() : std::string();
}
std::string ChromeContentClient::GetUserAgent() const {

Powered by Google App Engine
This is Rietveld 408576698