Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 1805423002: Revert of Add tests for input.ime.* APIs. (Closed)

Created:
4 years, 9 months ago by Nico
Modified:
4 years, 9 months ago
Reviewers:
Shu Chen, Azure Wei
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add tests for input.ime.* APIs. (patchset #3 id:40001 of https://codereview.chromium.org/1780523006/ ) Reason for revert: Tests don't reliably pass, see http://crbug.com/595355 Original issue's description: > Add tests for input.ime.* APIs. > > Make chromeos::MockIMEInputContextHandler as ui::MockIMEInputContextHandler used for all platforms. > Add tests for input.ime.onFocus/onBlur/onCompositionBoundsChanged/setComposition/commitText. > > BUG=517773 > TEST=browser_test --gtest_filter=InputImeApiTest.* > > Committed: https://crrev.com/e28639662994ed0f2dd9470e95feceaa421e3d70 > Cr-Commit-Position: refs/heads/master@{#381437} TBR=shuchen@chromium.org,azurewei@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517773 Committed: https://crrev.com/2c4a1c93356736afd75c48008e52b53f44a8270a Cr-Commit-Position: refs/heads/master@{#381478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -113 lines) Patch
M chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc View 3 chunks +4 lines, -38 lines 0 comments Download
M chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js View 3 chunks +2 lines, -63 lines 0 comments Download
M ui/base/ime/dummy_text_input_client.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/base/ime/dummy_text_input_client.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Revert of Add tests for input.ime.* APIs.
4 years, 9 months ago (2016-03-16 17:05:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805423002/1
4 years, 9 months ago (2016-03-16 17:05:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 17:06:08 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 17:10:33 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c4a1c93356736afd75c48008e52b53f44a8270a
Cr-Commit-Position: refs/heads/master@{#381478}

Powered by Google App Engine
This is Rietveld 408576698