Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1805403003: Re-enable oortonline benchmark on windows (Closed)

Created:
4 years, 9 months ago by fmeawad
Modified:
4 years, 9 months ago
Reviewers:
eakuefner, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable oortonline benchmark on windows The crash was due to an excessive amount of trace events logged due to direct calls from webgl into v8 primitives. The trace events on the v8 primitives have been removed. BUG=590761 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/ce376a92665ed53ae2a75507c2daf9cf7d184be4 Cr-Commit-Position: refs/heads/master@{#381505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/perf/benchmarks/oortonline.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
fmeawad
PTAL
4 years, 9 months ago (2016-03-16 17:08:44 UTC) #3
eakuefner
lgtm please keep an eye on the waterfall.
4 years, 9 months ago (2016-03-16 17:09:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805403003/1
4 years, 9 months ago (2016-03-16 17:15:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 18:49:02 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 18:50:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce376a92665ed53ae2a75507c2daf9cf7d184be4
Cr-Commit-Position: refs/heads/master@{#381505}

Powered by Google App Engine
This is Rietveld 408576698