Added MediaRouterUIBrowserTest::toolbar_action_view_ to a Widget.

chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <limits>
@@ skipping 224 matching lines @@
   }
 
   scoped_ptr<views::InkDropHover> CreateInkDropHover() const override {
     if (!ShouldShowInkDropHover())
       return nullptr;
     return make_scoped_ptr(new views::InkDropHover(
         size(), 0, GetInkDropCenter(), GetInkDropBaseColor()));
   }
 
   SkColor GetInkDropBaseColor() const override {
-    // TODO(bruthig): Inject the color instead of assuming a ThemeProvider is
-    // always available. Fall back on LabelButton::GetInkDropBaseColor() so as
-    // to avoid difficult to track down crashes.
-    return GetThemeProvider()
-               ? GetThemeProvider()->GetColor(
-                     ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON)
-               : views::LabelButton::GetInkDropBaseColor();
+    DCHECK(GetThemeProvider());

[Evan Stade, 2016/03/17 21:41:35]

the style guide says not to dcheck right before derefing

[bruthig, 2016/03/18 00:22:41]

Yeah, I know that the style guide says to avoid this, and I was hoping this
would start a discussion.
I argue that they are super useful because I spent almost a day tracking down
this error with manual log lines because there was no stack trace in the logs
when this was failing on the bots. Unfortunately the logs have been purged for
that particular run so I can't show you the proof.  Is there an alternative to
solution to this?

[Evan Stade, 2016/03/18 01:20:22]

add a debug line: base::debug::StackTrace().Print();

[bruthig, 2016/03/18 15:39:21]

Removed.

+    return GetThemeProvider()->GetColor(
+        ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON);
   }
 
  private:
   scoped_ptr<gfx::SlideAnimation> show_animation_;
 
   // Controls the visual feedback for the button state.
   views::ButtonInkDropDelegate ink_drop_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(BookmarkButtonBase);
 };
@@ skipping 76 matching lines @@
   }
 
   scoped_ptr<views::InkDropHover> CreateInkDropHover() const override {
     if (!ShouldShowInkDropHover())
       return nullptr;
     return make_scoped_ptr(new views::InkDropHover(
         size(), 0, GetInkDropCenter(), GetInkDropBaseColor()));
   }
 
   SkColor GetInkDropBaseColor() const override {
-    return GetThemeProvider()
-               ? GetThemeProvider()->GetColor(
-                     ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON)
-               : views::LabelButton::GetInkDropBaseColor();
+    DCHECK(GetThemeProvider());
+    return GetThemeProvider()->GetColor(
+        ThemeProperties::COLOR_TOOLBAR_BUTTON_ICON);
   }
 
  private:
   // Controls the visual feedback for the button state.
   views::ButtonInkDropDelegate ink_drop_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(BookmarkMenuButtonBase);
 };
 
 // BookmarkFolderButton -------------------------------------------------------
@@ skipping 1788 matching lines @@
     return;
   apps_page_shortcut_->SetVisible(visible);
   UpdateBookmarksSeparatorVisibility();
   LayoutAndPaint();
 }
 
 void BookmarkBarView::OnShowManagedBookmarksPrefChanged() {
   if (UpdateOtherAndManagedButtonsVisibility())
     LayoutAndPaint();
 }