Add traces for main omnibox providers

Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.

Committed: https://crrev.com/46959e833a3bfedbd783f829094a0824e756ee65
Cr-Commit-Position: refs/heads/master@{#381913}

Committed: https://crrev.com/dd768d54bd4a775b8b9f17819f1535ed643d8c8b
Cr-Commit-Position: refs/heads/master@{#383360}

[Mark P, 2016-03-17 18:15:06]

Description was changed from

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.


R=mpearson@chromium.org
==========

to

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.


R=mpearson@chromium.org
==========

[Mark P, 2016-03-17 18:15:06]

mpearson@chromium.org changed reviewers:
+ pkasting@chromium.org
- mpearson@chromium.org

[Mark P, 2016-03-17 18:15:22]

Description was changed from

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.


R=mpearson@chromium.org
==========

to

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.
==========

[Mark P, 2016-03-17 18:19:42]

mpearson@chromium.org changed reviewers:
+ mpearson@chromium.org

[Mark P, 2016-03-17 18:19:42]

This seems good to me.  The about:histogram and about:omnibox output usually
provides the information we need.  However, I'm not aware of any harm in adding
traces, and I imagine it would be useful to have these traced events show up on
the tracing and jank dashboards for comparison with other sources of jank.  That
said, I'd feel better if pkasting@ does the official sign-off for this review. 
He's more attuned to performance issues and to infrastructure frameworks (as
TRACEing is) in the omnibox code than me.  The code looks fine to me.  I think
you selected a good, appropriate selection of functions to trace.

--mark

[Peter Kasting, 2016-03-17 19:17:05]

LGTM

[Alexander Yashkin, 2016-03-18 07:34:27]

The CQ bit was checked by a-v-y@yandex-team.ru

[commit-bot: I haz the power, 2016-03-18 07:34:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805363002/1

[commit-bot: I haz the power, 2016-03-18 08:46:43]

Description was changed from

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.
==========

to

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.
==========

[commit-bot: I haz the power, 2016-03-18 08:46:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-18 08:47:39]

Description was changed from

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.
==========

to

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.

Committed: https://crrev.com/46959e833a3bfedbd783f829094a0824e756ee65
Cr-Commit-Position: refs/heads/master@{#381913}
==========

[commit-bot: I haz the power, 2016-03-18 08:47:40]

Patchset 1 (id:??) landed as
https://crrev.com/46959e833a3bfedbd783f829094a0824e756ee65
Cr-Commit-Position: refs/heads/master@{#381913}

[phoglund_chromium, 2016-03-18 14:35:08]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1815653002/ by phoglund@chromium.org.

The reason for reverting is: I think the new category breaks
SingleProcessTracingBrowserTest.TestMemoryInfra:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2....
It may be as simple as increasing MAX_CATEGORY_GROUPS but I'll leave that to the
CL author.

14141:14175:0318/032221:FATAL:trace_log.cc(537)] Check failed: category_index <
MAX_CATEGORY_GROUPS. must increase MAX_CATEGORY_GROUPS
#0 0x7f9a37d4574e base::debug::StackTrace::StackTrace()
#1 0x7f9a37da5d5f logging::LogMessage::~LogMessage()
#2 0x7f9a37f4910c base::trace_event::TraceLog::GetCategoryGroupEnabledInternal()
#3 0x7f9a37f48daa base::trace_event::TraceLog::GetCategoryGroupEnabled()
#4 0x7f9a2d3c1ef1 storage::FileSystemUsageCache::CloseCacheFiles()
#5 0x7f9a2d3c1e34 storage::FileSystemUsageCache::~FileSystemUsageCache()
#6 0x7f9a2d42aaf7 base::DeleteHelper<>::DoDelete().

[Alexander Yashkin, 2016-03-18 19:24:46]

Description was changed from

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.

Committed: https://crrev.com/46959e833a3bfedbd783f829094a0824e756ee65
Cr-Commit-Position: refs/heads/master@{#381913}
==========

to

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.

Committed: https://crrev.com/46959e833a3bfedbd783f829094a0824e756ee65
Cr-Commit-Position: refs/heads/master@{#381913}
==========

[Alexander Yashkin, 2016-03-18 19:24:46]

a-v-y@yandex-team.ru changed reviewers:
+ oysteine@chromium.org

[Alexander Yashkin, 2016-03-18 19:25:50]

The CQ bit was checked by a-v-y@yandex-team.ru

[Alexander Yashkin, 2016-03-18 19:25:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1805363002/#ps20001
(title: "Updated trace categories limit")

[Alexander Yashkin, 2016-03-18 19:26:18]

The CQ bit was unchecked by a-v-y@yandex-team.ru

[commit-bot: I haz the power, 2016-03-18 19:26:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805363002/20001

[Alexander Yashkin, 2016-03-22 07:35:01]

The CQ bit was checked by a-v-y@yandex-team.ru

[Alexander Yashkin, 2016-03-22 07:35:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1805363002/#ps40001
(title: "Added TBR=oysteine@chromium.org")

[commit-bot: I haz the power, 2016-03-22 07:35:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805363002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805363002/40001

[commit-bot: I haz the power, 2016-03-22 07:44:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 07:44:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alexander Yashkin, 2016-03-22 07:49:38]

a-v-y@yandex-team.ru changed reviewers:
+ nduca@chromium.org

[Alexander Yashkin, 2016-03-25 08:55:55]

PTAL  nduca, Oystein

[oystein (OOO til 10th of July), 2016-03-25 18:11:27]

base/trace_event LGTM

[Alexander Yashkin, 2016-03-25 19:37:01]

The CQ bit was checked by a-v-y@yandex-team.ru

[commit-bot: I haz the power, 2016-03-25 19:37:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805363002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805363002/40001

[commit-bot: I haz the power, 2016-03-25 21:07:58]

Description was changed from

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.

Committed: https://crrev.com/46959e833a3bfedbd783f829094a0824e756ee65
Cr-Commit-Position: refs/heads/master@{#381913}
==========

to

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.

Committed: https://crrev.com/46959e833a3bfedbd783f829094a0824e756ee65
Cr-Commit-Position: refs/heads/master@{#381913}
==========

[commit-bot: I haz the power, 2016-03-25 21:08:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-25 21:08:56]

Description was changed from

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.

Committed: https://crrev.com/46959e833a3bfedbd783f829094a0824e756ee65
Cr-Commit-Position: refs/heads/master@{#381913}
==========

to

==========
Add traces for main omnibox providers

Add trace events for main omnibox providers. They are useful when
analyzing problems with omnibox slow response and lagginess while
typing, like issue 178705.

Committed: https://crrev.com/46959e833a3bfedbd783f829094a0824e756ee65
Cr-Commit-Position: refs/heads/master@{#381913}

Committed: https://crrev.com/dd768d54bd4a775b8b9f17819f1535ed643d8c8b
Cr-Commit-Position: refs/heads/master@{#383360}
==========

[commit-bot: I haz the power, 2016-03-25 21:08:57]

Patchset 3 (id:??) landed as
https://crrev.com/dd768d54bd4a775b8b9f17819f1535ed643d8c8b
Cr-Commit-Position: refs/heads/master@{#383360}

[Mark P, 2016-04-21 22:32:22]

On 2016/03/25 21:08:57, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/dd768d54bd4a775b8b9f17819f1535ed643d8c8b
> Cr-Commit-Position: refs/heads/master@{#383360}

Have any of the people interested in this looked at it on the profiling
dashboard yet?

(If so, please start a thread internally.)

--mark