Do not pass default values from GN to ld_bfd.py if CXX is specified

Do not pass default values from GN to ld_bfd.py if CXX is specified

In src/trusted/service_runtime/linux/nacl_bootstrap.gyp, $CXX is
preferred to default values like "arm-linux-gnueabihf-g++".

GN should do the same thing when building for Chrome OS devices.

BUG=433082
Committed: https://chromium.googlesource.com/native_client/src/native_client/+/d0b46e4468ba1e0539804932293f9ac1c2819c33

[hashimoto, 2016-03-16 10:10:42]

hashimoto@chromium.org changed reviewers:
+ bradnelson@chromium.org

[hashimoto, 2016-03-16 10:12:56]

cc: dpranke@chromium.org

[bradn, 2016-03-16 17:30:39]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-03-16 17:30:39]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-03-16 17:30:39]

lgtm

[commit-bot: I haz the power, 2016-03-16 17:30:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805353002/1

[commit-bot: I haz the power, 2016-03-16 17:34:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 17:34:19]

Try jobs failed on following builders:
  nacl-presubmit on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/nacl-presubmit/builds/690)

[Dirk Pranke, 2016-03-16 22:30:28]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-03-16 22:30:28]

lgtm

[hashimoto, 2016-03-17 05:47:15]

Thank you for reviewing this change, Brad.

Seems the presubmit check didn't recognize your LGTM as a valid one since it was
made with your google.com account.

Could you give me an LGTM from your chromium.org account?

[hashimoto, 2016-03-17 11:46:06]

Found that this change breaks the build when building with target_os="chromeos",
but leaving cros_target_cxx unspecified (i.e. building Chrome for Linux with
target_os="chromeos" for UI development).

Changed the code to check if cros_target_cxx is defined (it'd be nicer if we
could just use target_toolchain's cxx value here, but I'm not sure if it's
possible or not).
PTAL

[bradnelson, 2016-03-17 18:28:42]

lgtm

[hashimoto, 2016-03-18 04:02:39]

The CQ bit was checked by hashimoto@chromium.org

[hashimoto, 2016-03-18 04:02:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, bradnelson@google.com
Link to the patchset: https://codereview.chromium.org/1805353002/#ps20001
(title: "Check if defined")

[commit-bot: I haz the power, 2016-03-18 04:02:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805353002/20001

[commit-bot: I haz the power, 2016-03-18 04:58:23]

Description was changed from

==========
Do not pass default values from GN to ld_bfd.py if CXX is specified

In src/trusted/service_runtime/linux/nacl_bootstrap.gyp, $CXX is
preferred to default values like "arm-linux-gnueabihf-g++".

GN should do the same thing when building for Chrome OS devices.

BUG=433082
==========

to

==========
Do not pass default values from GN to ld_bfd.py if CXX is specified

In src/trusted/service_runtime/linux/nacl_bootstrap.gyp, $CXX is
preferred to default values like "arm-linux-gnueabihf-g++".

GN should do the same thing when building for Chrome OS devices.

BUG=433082

Committed:
https://chromium.googlesource.com/native_client/src/native_client/+/d0b46e446...
==========

[commit-bot: I haz the power, 2016-03-18 04:58:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/d0b46e446...