Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1805343003: DevTools: rename script_formatter_worker into formatter_worker (Closed)

Created:
4 years, 9 months ago by lushnikov
Modified:
4 years, 9 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: rename script_formatter_worker into formatter_worker There are two reasons to rename the worker: - The formatting worker formats all kinds of formats. - There's a confustion between JavaScriptFormatter.js and ScriptFormatterWorker.js The patch also splits out FormattedContentBuilder into its own file. BUG=none R=dgozman, pfeldman Committed: https://crrev.com/6144890b6e847d144ca7b719c30e25c7804e45a7 Cr-Commit-Position: refs/heads/master@{#381623}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -1301 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger/script-extract-outline.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 4 chunks +7 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/formatter_worker/CSSFormatter.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/formatter_worker/FormattedContentBuilder.js View 1 chunk +160 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/formatter_worker/FormatterWorker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptFormatter.js View 1 chunk +0 lines, -155 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/formatter_worker/module.json View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/devtools/front_end/script_formatter_worker/CSSFormatter.js View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/script_formatter_worker/JavaScriptFormatter.js View 1 chunk +0 lines, -454 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/script_formatter_worker/ScriptFormatterWorker.js View 1 chunk +0 lines, -535 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/script_formatter_worker/module.json View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSParser.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatter.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
lushnikov
зефд
4 years, 9 months ago (2016-03-16 18:52:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805343003/1
4 years, 9 months ago (2016-03-16 18:52:46 UTC) #3
dgozman
lgtm
4 years, 9 months ago (2016-03-16 19:02:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805343003/1
4 years, 9 months ago (2016-03-16 20:05:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/197566)
4 years, 9 months ago (2016-03-16 22:09:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805343003/1
4 years, 9 months ago (2016-03-16 23:09:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805343003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805343003/20001
4 years, 9 months ago (2016-03-16 23:44:12 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 01:13:59 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 01:15:38 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6144890b6e847d144ca7b719c30e25c7804e45a7
Cr-Commit-Position: refs/heads/master@{#381623}

Powered by Google App Engine
This is Rietveld 408576698