third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp - Issue 1805343002: Add unicode flag to blink::ScriptRegexp, and measure incompatibility for |pattern| content attribut…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

Issue 1805343002: Add unicode flag to blink::ScriptRegexp, and measure incompatibility for |pattern| content attribut… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.h ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

index 6344061425d107f84dcda371c3de7e3128f2ad3c..8fc90321d7ff4680422a97f63e808abbb618f94f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp

@@ -35,7 +35,7 @@

namespace blink {

-ScriptRegexp::ScriptRegexp(const String& pattern, TextCaseSensitivity caseSensitivity, MultilineMode multilineMode)

+ScriptRegexp::ScriptRegexp(const String& pattern, TextCaseSensitivity caseSensitivity, MultilineMode multilineMode, CharacterMode charMode)

{

v8::Isolate* isolate = v8::Isolate::GetCurrent();

v8::HandleScope handleScope(isolate);

@@ -48,6 +48,8 @@ ScriptRegexp::ScriptRegexp(const String& pattern, TextCaseSensitivity caseSensit

flags |= v8::RegExp::kIgnoreCase;

if (multilineMode == MultilineEnabled)

flags |= v8::RegExp::kMultiline;

+ if (charMode == UTF16)

+ flags |= v8::RegExp::kUnicode;

v8::Local<v8::RegExp> regex;

if (v8::RegExp::New(context, v8String(isolate, pattern), static_cast<v8::RegExp::Flags>(flags)).ToLocal(&regex))

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.h ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »