Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: Source/heap/Visitor.cpp

Issue 180533004: Oilpan: deprecate GCInfO::typeMarker and replace its checks w/ gcInfo ptr compare (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/heap/Visitor.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/heap/Visitor.cpp
diff --git a/Source/heap/Visitor.cpp b/Source/heap/Visitor.cpp
index 608dbc70d82974a2bcf7f512e771162f0882bae4..2df85759e024d154934a461ebcfef1b7d850b5b1 100644
--- a/Source/heap/Visitor.cpp
+++ b/Source/heap/Visitor.cpp
@@ -37,21 +37,20 @@
namespace WebCore {
#ifndef NDEBUG
-void Visitor::checkTypeMarker(const void* payload, const char* marker)
+void Visitor::checkGCInfo(const void* payload, const GCInfo* gcInfo)
{
FinalizedHeapObjectHeader::fromPayload(payload)->checkHeader();
- ASSERT(FinalizedHeapObjectHeader::fromPayload(payload)->typeMarker() == marker);
+ ASSERT(FinalizedHeapObjectHeader::fromPayload(payload)->gcInfo() == gcInfo);
}
#define DEFINE_VISITOR_CHECK_MARKER(Type) \
- void Visitor::checkTypeMarker(const Type* payload, const char* marker) \
+ void Visitor::checkGCInfo(const Type* payload, const GCInfo* gcInfo) \
{ \
HeapObjectHeader::fromPayload(payload)->checkHeader(); \
Type* object = const_cast<Type*>(payload); \
Address addr = pageHeaderAddress(reinterpret_cast<Address>(object)); \
BaseHeapPage* page = reinterpret_cast<BaseHeapPage*>(addr); \
- ASSERT(page->gcInfo()); \
- ASSERT(page->gcInfo()->m_typeMarker == marker); \
+ ASSERT(page->gcInfo() == gcInfo); \
}
FOR_EACH_TYPED_HEAP(DEFINE_VISITOR_CHECK_MARKER)
@@ -60,7 +59,6 @@ FOR_EACH_TYPED_HEAP(DEFINE_VISITOR_CHECK_MARKER)
#define DEFINE_DO_NOTHING_TRAIT(type) \
const GCInfo GCInfoTrait<type>::info = { \
- #type, \
doNothingTrace, \
0, /* no finalizer method */ \
false \
« no previous file with comments | « Source/heap/Visitor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698