Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180533004: Oilpan: deprecate GCInfO::typeMarker and replace its checks w/ gcInfo ptr compare (Closed)

Created:
6 years, 9 months ago by kouhei (in TOK)
Modified:
6 years, 9 months ago
CC:
blink-reviews, haraken, Mads Ager (chromium)
Visibility:
Public.

Description

Oilpan: deprecate GCInfo::typeMarker and replace its checks w/ gcInfo ptr compare BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -44 lines) Patch
M Source/heap/Heap.h View 9 chunks +4 lines, -13 lines 0 comments Download
M Source/heap/Visitor.h View 10 chunks +9 lines, -25 lines 0 comments Download
M Source/heap/Visitor.cpp View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kouhei (in TOK)
PTAL.
6 years, 9 months ago (2014-03-06 05:07:40 UTC) #1
haraken
Looks like good refactoring. LGTM. Let's wait for Slava's approval.
6 years, 9 months ago (2014-03-06 05:12:00 UTC) #2
Vyacheslav Egorov (Google)
LGTM!
6 years, 9 months ago (2014-03-06 07:33:59 UTC) #3
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-06 07:50:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/180533004/1
6 years, 9 months ago (2014-03-06 07:50:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 08:58:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-06 08:58:51 UTC) #7
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 9 months ago (2014-03-06 09:00:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/180533004/1
6 years, 9 months ago (2014-03-06 09:00:32 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 10:06:50 UTC) #10
Message was sent while issue was closed. 
Change committed as 168616

Powered by Google App Engine
This is Rietveld 408576698