Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1805313002: Revert of third_party: Add missing scaler.xml file. (Closed)

Created:
4 years, 9 months ago by martiniss
Modified:
4 years, 9 months ago
Reviewers:
cbiesinger, reveman, piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of third_party: Add missing scaler.xml file. (patchset #1 id:1 of https://codereview.chromium.org/1807463004/ ) Reason for revert: Possibly broke presubmit: see https://crbug.com/595198 Original issue's description: > third_party: Add missing scaler.xml file. > > This was supposed to be included in the change that added the > auto-generated scaler files. > > TBR=piman@chromium.org > BUG=549782 > > Committed: https://crrev.com/814b976192adb1003e2b513b063f0b04783eaeb2 > Cr-Commit-Position: refs/heads/master@{#381354} TBR=piman@chromium.org,reveman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549782 Committed: https://crrev.com/c6c13cb070770fcd696c2abe26494b567d8b8635 Cr-Commit-Position: refs/heads/master@{#381384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -208 lines) Patch
D third_party/wayland-protocols/src/unstable/scaler/scaler.xml View 1 chunk +0 lines, -208 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
martiniss
Created Revert of third_party: Add missing scaler.xml file.
4 years, 9 months ago (2016-03-16 02:30:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805313002/1
4 years, 9 months ago (2016-03-16 02:31:01 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-16 02:31:03 UTC) #4
cbiesinger
lgtm
4 years, 9 months ago (2016-03-16 02:33:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805313002/1
4 years, 9 months ago (2016-03-16 02:33:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 02:34:18 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 02:35:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6c13cb070770fcd696c2abe26494b567d8b8635
Cr-Commit-Position: refs/heads/master@{#381384}

Powered by Google App Engine
This is Rietveld 408576698