Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1805303002: Ensure that the ppp_class_data is freed when a PluginObject isn't created (Closed)

Created:
4 years, 9 months ago by raymes
Modified:
4 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that the ppp_class_data is freed when a PluginObject isn't created PluginObject creation can fail if there isn't a valid V8 context. In this case we need to take care to free the ppp_class_data. BUG=594926 Committed: https://crrev.com/ef46412b5f33167050076c125f81d670ec7bdab6 Cr-Commit-Position: refs/heads/master@{#381605}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/renderer/pepper/plugin_object.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
raymes
I suspect this is the bug though I haven't tested it on an lsan build.
4 years, 9 months ago (2016-03-16 01:51:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805303002/20001
4 years, 9 months ago (2016-03-16 01:55:01 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 05:20:40 UTC) #6
piman
LGTM, thanks a lot for looking at that!
4 years, 9 months ago (2016-03-16 23:51:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805303002/20001
4 years, 9 months ago (2016-03-17 00:26:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 00:33:01 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 00:34:32 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef46412b5f33167050076c125f81d670ec7bdab6
Cr-Commit-Position: refs/heads/master@{#381605}

Powered by Google App Engine
This is Rietveld 408576698