Issue 18053015: Roll gyp to r1656

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18053015: Roll gyp to r1656 (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, tfarina

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Roll gyp to r1656 r1656 contains a bug fix for the make generator to correctly regenerate Makefiles if a gyp was touched. Before, it would assume that it is running in the top-level directory. However, the v8 standalone build puts the generated Makefile into the out subdirectory, and so gyp failed to locate the gyp binary. BUG=none R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15388

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Committed patchset #1 manually as r15388 (presubmit successful).

7 years, 5 months ago (2013-06-28 15:20:12 UTC) #3

tfarina

7 years, 5 months ago (2013-07-04 23:21:50 UTC) #4

Message was sent while issue was closed.

Thanks Jochen! Now it's possible to use ninja :)

I have proposed this change in Apr 25.

Expand Messages | Collapse Messages