Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 18053005: Introduce SVGGraphicsElement IDL interface (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, lgombos, do_not_use
Visibility:
Public.

Description

Introduce SVGGraphicsElement IDL interface Introduce SVGGraphicsElement IDL interface as per the latest SVG specification: https://svgwg.org/svg2-draft/types.html#InterfaceSVGGraphicsElement BUG=253479 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153166

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -528 lines) Patch
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGEllipse.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGEllipse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGPath.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTransformableContainer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTransformableContainer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGAElement.cpp View 5 chunks +10 lines, -11 lines 0 comments Download
M Source/core/svg/SVGAElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCircleElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGCircleElement.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/svg/SVGCircleElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.idl View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/svg/SVGDefsElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGDefsElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGDefsElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGEllipseElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.idl View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.idl View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGGElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGGElement.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/svg/SVGGElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
A + Source/core/svg/SVGGraphicsElement.h View 3 chunks +12 lines, -12 lines 1 comment Download
A + Source/core/svg/SVGGraphicsElement.cpp View 6 chunks +22 lines, -20 lines 0 comments Download
A + Source/core/svg/SVGGraphicsElement.idl View 2 chunks +10 lines, -13 lines 2 comments Download
M Source/core/svg/SVGImageElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGImageElement.cpp View 8 chunks +10 lines, -11 lines 0 comments Download
M Source/core/svg/SVGImageElement.idl View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGLineElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGLineElement.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/svg/SVGLineElement.idl View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGPathElement.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPathElement.cpp View 4 chunks +6 lines, -7 lines 0 comments Download
M Source/core/svg/SVGPathElement.idl View 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/svg/SVGPolyElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGPolyElement.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPolygonElement.idl View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/svg/SVGPolylineElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGRectElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGRectElement.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/svg/SVGRectElement.idl View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGSVGElement.h View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/svg/SVGStyledElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStyledLocatableElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/svg/SVGStyledTransformableElement.h View 1 chunk +0 lines, -80 lines 0 comments Download
D Source/core/svg/SVGStyledTransformableElement.cpp View 1 chunk +0 lines, -167 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGUseElement.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 7 chunks +9 lines, -10 lines 0 comments Download
M Source/core/svg/SVGUseElement.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
do-not-use
7 years, 5 months ago (2013-06-27 15:55:37 UTC) #1
haraken
https://codereview.chromium.org/18053005/diff/1/Source/core/svg/SVGGraphicsElement.idl File Source/core/svg/SVGGraphicsElement.idl (right): https://codereview.chromium.org/18053005/diff/1/Source/core/svg/SVGGraphicsElement.idl#newcode40 Source/core/svg/SVGGraphicsElement.idl:40: [RaisesException] SVGMatrix getTransformToElement([Default=Undefined] optional SVGElement element); Where were these ...
7 years, 5 months ago (2013-06-27 16:04:20 UTC) #2
do-not-use
https://codereview.chromium.org/18053005/diff/1/Source/core/svg/SVGGraphicsElement.idl File Source/core/svg/SVGGraphicsElement.idl (right): https://codereview.chromium.org/18053005/diff/1/Source/core/svg/SVGGraphicsElement.idl#newcode40 Source/core/svg/SVGGraphicsElement.idl:40: [RaisesException] SVGMatrix getTransformToElement([Default=Undefined] optional SVGElement element); On 2013/06/27 16:04:20, ...
7 years, 5 months ago (2013-06-27 16:05:50 UTC) #3
haraken
> They come from SVGLocatable and SVGTransformable interfaces. Sorry, this is only > explained in ...
7 years, 5 months ago (2013-06-27 16:07:15 UTC) #4
Stephen Chennney
LGTM. It's great that you're doing all this for the project. https://codereview.chromium.org/18053005/diff/1/Source/core/svg/SVGGraphicsElement.h File Source/core/svg/SVGGraphicsElement.h (right): ...
7 years, 5 months ago (2013-06-27 16:18:48 UTC) #5
do-not-use
On 2013/06/27 16:18:48, Stephen Chenney wrote: > LGTM. It's great that you're doing all this ...
7 years, 5 months ago (2013-06-27 16:23:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18053005/1
7 years, 5 months ago (2013-06-27 17:27:19 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-06-27 19:23:50 UTC) #8
Message was sent while issue was closed.
Change committed as 153166

Powered by Google App Engine
This is Rietveld 408576698