Issue 18053: Linux: use WebKit HEAD's gtk2drawing.c

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18053: Linux: use WebKit HEAD's gtk2drawing.c (Closed)

Created:
11 years, 11 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review), Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	webkit/build/WebCore/SConscript	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	webkit/tools/test_shell/test_shell_gtk.cc	View		1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/18053/diff/1/3 File webkit/tools/test_shell/test_shell_gtk.cc (right): http://codereview.chromium.org/18053/diff/1/3#newcode45 Line 45: extern gint moz_gtk_init(); #include "gtkdrawing.h" ?

11 years, 11 months ago (2009-01-14 18:58:19 UTC) #2

Evan Martin

LGTM for now, maybe we'll revisit in real browser code

11 years, 11 months ago (2009-01-14 19:02:18 UTC) #3

Poke... can this be committed?

Expand Messages | Collapse Messages

Issue 18053: Linux: use WebKit HEAD's gtk2drawing.c (Closed)

Description

Patch Set 1 #

Messages