Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1805283002: [SPv2] Fix paint offset computation for LayoutTableCell in property tree builder (Closed)

Created:
4 years, 9 months ago by trchen
Modified:
4 years, 9 months ago
Reviewers:
pdr., Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPv2] Fix paint offset computation for LayoutTableCell in property tree builder The table cells have a weird quirk. Although their layout container is the row, are painted by the rows and can be affected by transforms on the row, their layout location is relative to the table section. (i.e. with the row's location baked-in) This CL adjusts table cell's paint offset in property tree builder in the same way as other layout/paint code does. BUG=593525 Committed: https://crrev.com/f0b4bc588c246586ffbb3fedc38444e674996913 Cr-Commit-Position: refs/heads/master@{#381397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
trchen
Thanks Xianzhu for figuring out the root cause!
4 years, 9 months ago (2016-03-16 01:41:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805283002/1
4 years, 9 months ago (2016-03-16 01:41:33 UTC) #4
pdr.
LGTM
4 years, 9 months ago (2016-03-16 02:57:56 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/183102)
4 years, 9 months ago (2016-03-16 03:19:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805283002/1
4 years, 9 months ago (2016-03-16 03:31:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 05:26:03 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 05:28:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0b4bc588c246586ffbb3fedc38444e674996913
Cr-Commit-Position: refs/heads/master@{#381397}

Powered by Google App Engine
This is Rietveld 408576698