Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1805273002:
MD Downloads: remove dangling, long gone flag (Closed)
|
Created:
4 years, 9 months ago by Dan Beam Modified:
4 years, 9 months ago Reviewers:
Ilya Sherman CC:
chromium-reviews, asvitkine+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Downloads: remove dangling, long gone flag
R=isherman@chromium.org
BUG=none
TEST=`git grep md-downloads`
Committed: https://crrev.com/2e0ba7b22dc533d059da03dbee4824e036754b2a
Cr-Commit-Position: refs/heads/master@{#381659}
Patch Set 1 #Patch Set 2 : . #
Total comments: 2
Patch Set 3 : historygrams.xml #
Messages
Total messages: 21 (10 generated)
Description was changed from ========== MD Downloads: remove dangling, long gone flags R=michaelpg@chromium.org BUG=none TEST=`git grep md-downloads` ========== to ========== MD Downloads: remove dangling, long gone flags R=isherman@chromium.org BUG=none TEST=`git grep md-downloads` ==========
dbeam@chromium.org changed reviewers: + isherman@chromium.org - michaelpg@chromium.org
https://codereview.chromium.org/1805273002/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1805273002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:73010: - <int value="1786229999" label="disable-md-downloads"/> No need to remove these from histograms.xml -- they ain't hurtin' anyone here :)
https://codereview.chromium.org/1805273002/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1805273002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:73010: - <int value="1786229999" label="disable-md-downloads"/> On 2016/03/16 01:03:47, Ilya Sherman wrote: > No need to remove these from histograms.xml -- they ain't hurtin' anyone here :) Done.
Description was changed from ========== MD Downloads: remove dangling, long gone flags R=isherman@chromium.org BUG=none TEST=`git grep md-downloads` ========== to ========== MD Downloads: remove dangling, long gone flag R=isherman@chromium.org BUG=none TEST=`git grep md-downloads` ==========
Browser test changes lgtm
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805273002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805273002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805273002/40001
Message was sent while issue was closed.
Description was changed from ========== MD Downloads: remove dangling, long gone flag R=isherman@chromium.org BUG=none TEST=`git grep md-downloads` ========== to ========== MD Downloads: remove dangling, long gone flag R=isherman@chromium.org BUG=none TEST=`git grep md-downloads` ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== MD Downloads: remove dangling, long gone flag R=isherman@chromium.org BUG=none TEST=`git grep md-downloads` ========== to ========== MD Downloads: remove dangling, long gone flag R=isherman@chromium.org BUG=none TEST=`git grep md-downloads` Committed: https://crrev.com/2e0ba7b22dc533d059da03dbee4824e036754b2a Cr-Commit-Position: refs/heads/master@{#381659} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2e0ba7b22dc533d059da03dbee4824e036754b2a Cr-Commit-Position: refs/heads/master@{#381659} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
