Adding Variable builders to cover all builders under master "chromium"

Adding Variable builders to cover all builders under master "chromium"

BUG=595183
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299314

[lijeffrey, 2016-03-16 00:59:54]

lijeffrey@chromium.org changed reviewers:
+ iannucci@chromium.org, sergeyberezin@chromium.org, stgao@chromium.org

[lijeffrey, 2016-03-16 00:59:54]

Hey guys,

This change adds a corresponding variable builder for each builder under master
"chromium" that Findit can run try jobs against. PTAL when you have the chance.

Thanks,
Jeff

[Sergey Berezin, 2016-03-16 01:52:20]

LGTM. I checked all the slave pools for CPU & disk capacity, only one small note
below - you may want to be careful how many and at what times you run your jobs
on the android pool.

https://codereview.chromium.org/1805263003/diff/1/masters/master.tryserver.ch...
File masters/master.tryserver.chromium.android/builders.pyl (right):

https://codereview.chromium.org/1805263003/diff/1/masters/master.tryserver.ch...
masters/master.tryserver.chromium.android/builders.pyl:151: "slave_pools":
["ccompute_bots_cq"],
The disk space on this pool is very healthy, adding a new build folder is fine:
http://shortn/_qIec7MCxuZ

However, please keep in mind that this pool is already slightly overloaded:
https://goto.google.com/salqx

[lijeffrey, 2016-03-16 07:09:34]

The CQ bit was checked by lijeffrey@chromium.org

[commit-bot: I haz the power, 2016-03-16 07:09:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805263003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805263003/1

[commit-bot: I haz the power, 2016-03-16 07:11:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 07:11:11]

Try jobs failed on following builders:
  Build Try Recipe Test Trusty64 on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Try%20Recipe%20...)
  Build Try Recipe Test Win64 on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Try%20Recipe%20...)

[lijeffrey, 2016-03-16 07:26:30]

The CQ bit was checked by lijeffrey@chromium.org

[lijeffrey, 2016-03-16 07:26:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org
Link to the patchset: https://codereview.chromium.org/1805263003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-03-16 07:26:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805263003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805263003/20001

[commit-bot: I haz the power, 2016-03-16 07:30:37]

Description was changed from

==========
Adding Variable builders to cover all builders under master "chromium"

BUG=595183
==========

to

==========
Adding Variable builders to cover all builders under master "chromium"

BUG=595183

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299314
==========

[commit-bot: I haz the power, 2016-03-16 07:30:38]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299314

[lijeffrey, 2016-03-16 07:32:13]

On 2016/03/16 07:30:38, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=299314

Thanks Sergey, we'll keep an eye out in case Findit is asking too much of the
slave pool.

[stgao, 2016-03-16 07:32:58]

https://codereview.chromium.org/1805263003/diff/1/masters/master.tryserver.ch...
File masters/master.tryserver.chromium.android/builders.pyl (right):

https://codereview.chromium.org/1805263003/diff/1/masters/master.tryserver.ch...
masters/master.tryserver.chromium.android/builders.pyl:151: "slave_pools":
["ccompute_bots_cq"],
On 2016/03/16 01:52:20, Sergey Berezin wrote:
> The disk space on this pool is very healthy, adding a new build folder is
fine:
> http://shortn/_qIec7MCxuZ
> 
> However, please keep in mind that this pool is already slightly overloaded:
> https://goto.google.com/salqx

Jeff, we need to be careful about using cq slave pools.
Is it possible to have an optional slave pool like those in win/mac/linux
tryservers that we use?

[chromium-reviews, 2016-03-16 17:40:55]

+ Ben

I remember speaking with Ben a couple weeks back who mentioned the pool
'ccompute_bots_cq' in builders.pyl under master.chromium.tryserver.android
was a residual name from some merge that happened a while back and isn't
actually used for cq, Ben can you please help confirm in case I have it
confused with something else?

Thanks,
Jeff

On Wed, Mar 16, 2016 at 12:32 AM, <stgao@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/1805263003/diff/1/masters/master.tryserver.ch...
> File masters/master.tryserver.chromium.android/builders.pyl (right):
>
>
>
https://codereview.chromium.org/1805263003/diff/1/masters/master.tryserver.ch...
> masters/master.tryserver.chromium.android/builders.pyl:151:
> "slave_pools": ["ccompute_bots_cq"],
> On 2016/03/16 01:52:20, Sergey Berezin wrote:
> > The disk space on this pool is very healthy, adding a new build folder
> is fine:
> > http://shortn/_qIec7MCxuZ
> >
> > However, please keep in mind that this pool is already slightly
> overloaded:
> > https://goto.google.com/salqx
>
> Jeff, we need to be careful about using cq slave pools.
> Is it possible to have an optional slave pool like those in
> win/mac/linux tryservers that we use?
>
> https://codereview.chromium.org/1805263003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[lijeffrey, 2016-03-16 17:42:42]

Description was changed from

==========
Adding Variable builders to cover all builders under master "chromium"

BUG=595183

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299314
==========

to

==========
Adding Variable builders to cover all builders under master "chromium"

BUG=595183

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299314
==========

[lijeffrey, 2016-03-16 17:42:42]

lijeffrey@chromium.org changed reviewers:
+ bpastene@chromium.org

[lijeffrey, 2016-03-16 17:45:34]

Hey Ben,

Do you mind a quick look at masters.chromium.tryserver.android/builders.pyl?
Just want to make sure 'ccompute_bots_cq' is safe to use (and not actually a cq
pool?).

Thanks!
Jeff

[Sergey Berezin, 2016-03-16 19:30:42]

On 2016/03/16 17:45:34, lijeffrey wrote:
> Hey Ben,
> 
> Do you mind a quick look at masters.chromium.tryserver.android/builders.pyl?
> Just want to make sure 'ccompute_bots_cq' is safe to use (and not actually a
cq
> pool?).
> 
> Thanks!
> Jeff

It *is* as CQ pool, and it's running jobs, and it's slightly overloaded:
https://goto.google.com/salqx

[lijeffrey, 2016-03-16 19:33:02]

On 2016/03/16 17:45:34, lijeffrey wrote:
> Hey Ben,
> 
> Do you mind a quick look at masters.chromium.tryserver.android/builders.pyl?
> Just want to make sure 'ccompute_bots_cq' is safe to use (and not actually a
cq
> pool?).
> 
> Thanks!
> Jeff

Per discussion with Ben the Android builder pool should be split anyway, so
we'll hold off on the android master restart until that change is in and point
the android variable builders to use that new proposed pool. We'll proceed with
the other master restarts to unblock Findit and restart Android separately.

Thanks,
Jeff