Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1805253002: Update GN readme. (Closed)

Created:
4 years, 9 months ago by brettw
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina, sshruthi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update GN readme. Committed: https://crrev.com/ea79f96b9cd4b36bc0df5e3676fe2de4d63e95e4 Cr-Commit-Position: refs/heads/master@{#381481}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M tools/gn/README.md View 1 2 chunks +10 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
brettw
4 years, 9 months ago (2016-03-15 23:48:39 UTC) #2
Dirk Pranke
lgtm w/ possible suggestion. https://codereview.chromium.org/1805253002/diff/1/tools/gn/README.md File tools/gn/README.md (right): https://codereview.chromium.org/1805253002/diff/1/tools/gn/README.md#newcode68 tools/gn/README.md:68: We could espeially use Mac ...
4 years, 9 months ago (2016-03-16 01:15:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805253002/20001
4 years, 9 months ago (2016-03-16 16:40:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 17:24:37 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 17:25:46 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea79f96b9cd4b36bc0df5e3676fe2de4d63e95e4
Cr-Commit-Position: refs/heads/master@{#381481}

Powered by Google App Engine
This is Rietveld 408576698