Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 18051010: Make use of templatized convienience functions for adding Hydrogen instructions. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make use of templatized convienience functions for adding Hydrogen instructions. Building on the previous changes from https://codereview.chromium.org/18050004/ this patch makes even more use of the templatized functions for adding Hydrogen instructions. R=danno@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -390 lines) Patch
M src/hydrogen.h View 2 chunks +30 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 110 chunks +228 lines, -387 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-06-28 07:53:55 UTC) #1
danno
I like this extension to my original patch, but for a style change of this ...
7 years, 5 months ago (2013-06-28 09:02:46 UTC) #2
Jakob Kummerow
Fine with me. I didn't perceive the "AddInstruction(new(zone()) ...)" sequence as a pain point, and ...
7 years, 5 months ago (2013-06-28 09:17:56 UTC) #3
danno
ok, unless there are other serious objections, lgtm
7 years, 5 months ago (2013-06-28 11:07:09 UTC) #4
Benedikt Meurer
7 years, 5 months ago (2013-06-28 11:50:09 UTC) #5
Committed patchset #1 manually as r15379 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698