Issue 1805093002: Don't create a LoFiBarPopupController if SnackbarManager is null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1805093002: Don't create a LoFiBarPopupController if SnackbarManager is null (Closed)

Created:
4 years, 9 months ago by megjablon

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Don't create a LoFiBarPopupController if SnackbarManager is null BUG=594381 Review URL: https://codereview.chromium.org/1803823002 Cr-Commit-Position: refs/heads/master@{#381078} (cherry picked from commit e08672445f26f16bf7ed5f217447140cb2f3311a) Committed: https://chromium.googlesource.com/chromium/src/+/064272d4a1867565bf48bdaae4b8223b1bb38e19

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

megjablon

4 years, 9 months ago (2016-03-15 18:27:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
064272d4a1867565bf48bdaae4b8223b1bb38e19.