Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1805023003: Update DefaultAccessPolicy Hierarchy Notifications (Closed)

Created:
4 years, 9 months ago by jonross
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update DefaultAccessPolicy Hierarchy Notifications Update ShouldNotifyOnHierarchyChange to not notify if the window was not created by that connection. Ignoring the existance of new/old parent. Re-enable tests that were failing due to this. TEST=WindowTreeClientTest BUG=594181 Committed: https://crrev.com/569e3ef13ec1913cd59c196c94a28609a3959985 Cr-Commit-Position: refs/heads/master@{#381297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M components/mus/ws/default_access_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_client_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jonross
Fixing the notification error, and bringing tests back on. PTAL
4 years, 9 months ago (2016-03-15 17:37:10 UTC) #2
sky
LGTM
4 years, 9 months ago (2016-03-15 17:56:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805023003/1
4 years, 9 months ago (2016-03-15 19:12:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 20:09:55 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 20:11:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/569e3ef13ec1913cd59c196c94a28609a3959985
Cr-Commit-Position: refs/heads/master@{#381297}

Powered by Google App Engine
This is Rietveld 408576698