Source/core/rendering/RenderTableSection.h - Issue 18050007: Height of fixed height cell is not proper when cell's row is under row spanning cell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTableSection.h

Issue 18050007: Height of fixed height cell is not proper when cell's row is under row spanning cell. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/tables/mozilla/core/cell_heights-expected.txt ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | Source/core/rendering/RenderTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderTableSection.h

diff --git a/Source/core/rendering/RenderTableSection.h b/Source/core/rendering/RenderTableSection.h

index 41c2359fa9400734224f7a3ab19a40c338b7febf..5f05d12ccdbf6474bdb8f631c312bc2812ac83ad 100644

--- a/Source/core/rendering/RenderTableSection.h

+++ b/Source/core/rendering/RenderTableSection.h

@@ -232,6 +232,10 @@ private:

void ensureRows(unsigned);

+ int getRowsHeightInRowSpan(RenderTableCell*, int&, Vector<int>&);

+ void distributeExtraRowSpanHeightToPrecentRows(RenderTableCell*, int, int&, Vector<int>&);

+ void distributeExtraRowSpanHeightToAutoRows(RenderTableCell*, int, int&, Vector<int>&);

+ void distributeExtraRowSpanHeightToRemainingRows(RenderTableCell*, int, int&, Vector<int>&);

void distributeRowSpanHeightToRows(SpanningRenderTableCells& rowSpanCells);

void distributeExtraLogicalHeightToPercentRows(int& extraLogicalHeight, int totalPercent);