Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Side by Side Diff: Source/core/rendering/RenderTableSection.h

Issue 18050007: Height of fixed height cell is not proper when cell's row is under row spanning cell. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments addressed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 virtual void paintObject(PaintInfo&, const LayoutPoint&); 225 virtual void paintObject(PaintInfo&, const LayoutPoint&);
226 226
227 virtual void imageChanged(WrappedImagePtr, const IntRect* = 0); 227 virtual void imageChanged(WrappedImagePtr, const IntRect* = 0);
228 228
229 virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAct ion) OVERRIDE; 229 virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAct ion) OVERRIDE;
230 230
231 int borderSpacingForRow(unsigned row) const { return m_grid[row].rowRenderer ? table()->vBorderSpacing() : 0; } 231 int borderSpacingForRow(unsigned row) const { return m_grid[row].rowRenderer ? table()->vBorderSpacing() : 0; }
232 232
233 void ensureRows(unsigned); 233 void ensureRows(unsigned);
234 234
235 void getRowsHeightInRowSpan(RenderTableCell*, int&, int&, Vector<int>&);
236 void distributeExtraRowSpanHeightToPrecentRows(RenderTableCell*, int, int&, Vector<int>&);
237 void distributeExtraRowSpanHeightToAutoRows(RenderTableCell*, int, int&, Vec tor<int>&);
238 void distributeExtraRowSpanHeightToRemainingRows(RenderTableCell*, int, int& , Vector<int>&);
235 void distributeRowSpanHeightToRows(SpanningRenderTableCells& rowSpanCells); 239 void distributeRowSpanHeightToRows(SpanningRenderTableCells& rowSpanCells);
236 240
237 void distributeExtraLogicalHeightToPercentRows(int& extraLogicalHeight, int totalPercent); 241 void distributeExtraLogicalHeightToPercentRows(int& extraLogicalHeight, int totalPercent);
238 void distributeExtraLogicalHeightToAutoRows(int& extraLogicalHeight, unsigne d autoRowsCount); 242 void distributeExtraLogicalHeightToAutoRows(int& extraLogicalHeight, unsigne d autoRowsCount);
239 void distributeRemainingExtraLogicalHeight(int& extraLogicalHeight); 243 void distributeRemainingExtraLogicalHeight(int& extraLogicalHeight);
240 244
241 void updateBaselineForCell(RenderTableCell*, unsigned row, LayoutUnit& basel ineDescent); 245 void updateBaselineForCell(RenderTableCell*, unsigned row, LayoutUnit& basel ineDescent);
242 246
243 bool hasOverflowingCell() const { return m_overflowingCells.size() || m_forc eSlowPaintPathWithOverflowingCell; } 247 bool hasOverflowingCell() const { return m_overflowingCells.size() || m_forc eSlowPaintPathWithOverflowingCell; }
244 void computeOverflowFromCells(unsigned totalRows, unsigned nEffCols); 248 void computeOverflowFromCells(unsigned totalRows, unsigned nEffCols);
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isTableSection()); 303 ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isTableSection());
300 return static_cast<const RenderTableSection*>(object); 304 return static_cast<const RenderTableSection*>(object);
301 } 305 }
302 306
303 // This will catch anyone doing an unnecessary cast. 307 // This will catch anyone doing an unnecessary cast.
304 void toRenderTableSection(const RenderTableSection*); 308 void toRenderTableSection(const RenderTableSection*);
305 309
306 } // namespace WebCore 310 } // namespace WebCore
307 311
308 #endif // RenderTableSection_h 312 #endif // RenderTableSection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698