third_party: Add secure_output_protocol target to wayland-protocols.

third_party: Add secure_output_protocol target to wayland-protocols.

BUG=549782
Committed: https://crrev.com/875a6cb61fef7d9ef5b003e48c524d3b8da440d4
Cr-Commit-Position: refs/heads/master@{#381530}

[reveman, 2016-03-15 21:38:32]

reveman@chromium.org changed reviewers:
+ dcastagna@chromium.org

[reveman, 2016-03-16 14:32:26]

+ddorwin fyi

[Daniele Castagna, 2016-03-16 18:15:00]

I'm not sure about using "contents" as plural everywhere, but as you noticed
offline this is what they use in wayland.

A native speaker can better comment on that.

https://codereview.chromium.org/1804973003/diff/20001/third_party/wayland-pro...
File
third_party/wayland-protocols/src/unstable/secure-contents/secure-contents-unstable-v1.xml
(right):

https://codereview.chromium.org/1804973003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/src/unstable/secure-contents/secure-contents-unstable-v1.xml:27:
<description summary="Protocol for securing surface contents">
nit: the other summaries seem to start with a lower case letter. But I see in
pointer-constraints they have the same inconsistency.

https://codereview.chromium.org/1804973003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/src/unstable/secure-contents/secure-contents-unstable-v1.xml:29:
contents from appearing in screenshots or from being viewed on non-secure
Maybe displayed instead of viewed? This is copied from android doc, right?
Also, non-secure output is not defined, but we probably want to leave it that
way.

https://codereview.chromium.org/1804973003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/src/unstable/secure-contents/secure-contents-unstable-v1.xml:61:
Informs the server that the client will not be using this
Is the indentation correct?

https://codereview.chromium.org/1804973003/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/src/unstable/secure-contents/secure-contents-unstable-v1.xml:74:
Instantiate an interface extension for the given wl_surface to
Indentation?

[reveman, 2016-03-16 19:22:36]

Description was changed from

==========
third_party: Add secure_contents_protocol target to wayland-protocols.

BUG=549782
==========

to

==========
third_party: Add secure_output_protocol target to wayland-protocols.

BUG=549782
==========

[reveman, 2016-03-16 19:23:12]

ptal

[Daniele Castagna, 2016-03-16 19:32:13]

lgtm

[reveman, 2016-03-16 19:37:23]

The CQ bit was checked by reveman@chromium.org

[reveman, 2016-03-16 19:37:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
dcastagna@chromium.org
Link to the patchset: https://codereview.chromium.org/1804973003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-16 19:37:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1804973003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1804973003/60001

[commit-bot: I haz the power, 2016-03-16 20:49:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-16 20:53:22]

Description was changed from

==========
third_party: Add secure_output_protocol target to wayland-protocols.

BUG=549782
==========

to

==========
third_party: Add secure_output_protocol target to wayland-protocols.

BUG=549782

Committed: https://crrev.com/875a6cb61fef7d9ef5b003e48c524d3b8da440d4
Cr-Commit-Position: refs/heads/master@{#381530}
==========

[commit-bot: I haz the power, 2016-03-16 20:53:23]

Patchset 4 (id:??) landed as
https://crrev.com/875a6cb61fef7d9ef5b003e48c524d3b8da440d4
Cr-Commit-Position: refs/heads/master@{#381530}