Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1804953002: [wasm] Int64Lowering of I64ReinterpretF64. (Closed)

Created:
4 years, 9 months ago by ahaas
Modified:
4 years, 9 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Int64Lowering of I64ReinterpretF64. The implementation is done by storing to and loading from memory. R=titzer@chromium.org Committed: https://crrev.com/b484cc12f339fb591a6790f34c99196336ec7272 Cr-Commit-Position: refs/heads/master@{#34784}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Removed unused variables. #

Patch Set 4 : Removed unused variables. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -8 lines) Patch
M src/compiler/int64-lowering.cc View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ahaas
4 years, 9 months ago (2016-03-15 08:02:24 UTC) #1
titzer
lgtm
4 years, 9 months ago (2016-03-15 08:30:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804953002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804953002/60001
4 years, 9 months ago (2016-03-15 11:51:03 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-15 12:17:15 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 12:18:18 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b484cc12f339fb591a6790f34c99196336ec7272
Cr-Commit-Position: refs/heads/master@{#34784}

Powered by Google App Engine
This is Rietveld 408576698