Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 1804913002: [wasm] Turn off tests for mips and x87. (Closed)

Created:
4 years, 9 months ago by ahaas
Modified:
4 years, 9 months ago
Reviewers:
titzer, v8-mips-ports
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Turn off tests for mips and x87. The tests require the implementation of Int32PairAdd and Word32PairShl. R=titzer@chromium.org, v8-mips-ports@googlegroups.com Committed: https://crrev.com/3a2cc90cb4d7909252f8500463d62f92692806ab Cr-Commit-Position: refs/heads/master@{#34782}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M test/cctest/compiler/test-run-machops.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
ahaas
4 years, 9 months ago (2016-03-15 05:46:37 UTC) #1
titzer
lgtm
4 years, 9 months ago (2016-03-15 08:22:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804913002/20001
4 years, 9 months ago (2016-03-15 11:02:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-15 11:03:50 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 11:04:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a2cc90cb4d7909252f8500463d62f92692806ab
Cr-Commit-Position: refs/heads/master@{#34782}

Powered by Google App Engine
This is Rietveld 408576698