Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1804863002: Refactor RegionTree (Closed)

Created:
4 years, 9 months ago by keishi
Modified:
4 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor RegionTree This creates a new class, RegionTree, so we can reference the binary search tree and the mutex as one thing. BUG=591606 Committed: https://crrev.com/5227ab950a8d9de588844a3109a16094041c13a8 Cr-Commit-Position: refs/heads/master@{#381451}

Patch Set 1 #

Total comments: 6

Patch Set 2 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -66 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 3 chunks +7 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PageMemory.h View 1 6 chunks +31 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PageMemory.cpp View 1 6 chunks +34 lines, -18 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
keishi
Prerequisite for the "ThreadHeap CL" https://codereview.chromium.org/1477023003/ This creates a new class to bundle the RegionTree ...
4 years, 9 months ago (2016-03-15 04:28:55 UTC) #5
haraken
https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/platform/heap/HeapPage.cpp File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right): https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/platform/heap/HeapPage.cpp#newcode429 third_party/WebKit/Source/platform/heap/HeapPage.cpp:429: Heap::addPageMemoryRegion(region); Does addPageMemoryRegion need to be a method of ...
4 years, 9 months ago (2016-03-15 05:49:51 UTC) #6
keishi
https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/platform/heap/HeapPage.cpp File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right): https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/platform/heap/HeapPage.cpp#newcode429 third_party/WebKit/Source/platform/heap/HeapPage.cpp:429: Heap::addPageMemoryRegion(region); On 2016/03/15 05:49:50, haraken wrote: > > Does ...
4 years, 9 months ago (2016-03-15 07:48:43 UTC) #7
haraken
Looks nicer. LGTM.
4 years, 9 months ago (2016-03-15 13:12:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804863002/20001
4 years, 9 months ago (2016-03-16 01:29:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/157422)
4 years, 9 months ago (2016-03-16 01:39:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804863002/20001
4 years, 9 months ago (2016-03-16 11:40:25 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 14:47:10 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 14:48:34 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5227ab950a8d9de588844a3109a16094041c13a8
Cr-Commit-Position: refs/heads/master@{#381451}

Powered by Google App Engine
This is Rietveld 408576698