Refactor RegionTree

Refactor RegionTree

This creates a new class, RegionTree, so we can reference the binary search tree and the mutex as one thing.

BUG=591606
Committed: https://crrev.com/5227ab950a8d9de588844a3109a16094041c13a8
Cr-Commit-Position: refs/heads/master@{#381451}

[keishi, 2016-03-15 04:11:26]

Description was changed from

==========
Refactor RegionTree

BUG=
==========

to

==========
Refactor RegionTree

We create a RegionTree so we can reference the binary search tree and the mutex
as one thing.

BUG=None
==========

[keishi, 2016-03-15 04:12:03]

Description was changed from

==========
Refactor RegionTree

We create a RegionTree so we can reference the binary search tree and the mutex
as one thing.

BUG=None
==========

to

==========
Refactor RegionTree

This creates a new class, RegionTree, so we can reference the binary search tree
and the mutex as one thing.

BUG=None
==========

[keishi, 2016-03-15 04:13:24]

Description was changed from

==========
Refactor RegionTree

This creates a new class, RegionTree, so we can reference the binary search tree
and the mutex as one thing.

BUG=None
==========

to

==========
Refactor RegionTree

This creates a new class, RegionTree, so we can reference the binary search tree
and the mutex as one thing.

BUG=591606
==========

[keishi, 2016-03-15 04:28:54]

keishi@chromium.org changed reviewers:
+ haraken@chromium.org, oilpan-reviews@chromium.org

[keishi, 2016-03-15 04:28:55]

Prerequisite for the "ThreadHeap CL"
https://codereview.chromium.org/1477023003/

This creates a new class to bundle the RegionTree and mutex together.
By doing so, in the "ThreadHeap CL", PageMemoryRegion can remove itself from the
RegionTree without referencing the ThreadHeap.

[haraken, 2016-03-15 05:49:51]

https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right):

https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/HeapPage.cpp:429:
Heap::addPageMemoryRegion(region);

Does addPageMemoryRegion need to be a method of Heap? It looks better if we
could call region->add().

https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/PageMemory.cpp (right):

https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/PageMemory.cpp:98:
region->setRegionTree(this);

I'd prefer removing setRegionTree. It looks nicer to introduce
PageMemoryRegion::add() and set m_regionTree in the add() method.

https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/PageMemory.h (right):

https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/PageMemory.h:99: RegionTree*
getRegionTree() const { return m_regionTree; }

Is this used?

[keishi, 2016-03-15 07:48:43]

https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/HeapPage.cpp (right):

https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/HeapPage.cpp:429:
Heap::addPageMemoryRegion(region);
On 2016/03/15 05:49:50, haraken wrote:
> 
> Does addPageMemoryRegion need to be a method of Heap? It looks better if we
> could call region->add().

Done. I had the addPageMemoryRegion because regionTree was local to Heap.cpp.
Changed to use Heap::getRegionTree. The RegionTree is passed from *PageArena so
pageMemory doesn't need to use Heap.

https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/PageMemory.cpp (right):

https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/PageMemory.cpp:98:
region->setRegionTree(this);
On 2016/03/15 05:49:50, haraken wrote:
> 
> I'd prefer removing setRegionTree. It looks nicer to introduce
> PageMemoryRegion::add() and set m_regionTree in the add() method.

Done.

https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/PageMemory.h (right):

https://codereview.chromium.org/1804863002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/PageMemory.h:99: RegionTree*
getRegionTree() const { return m_regionTree; }
On 2016/03/15 05:49:50, haraken wrote:
> 
> Is this used?

Removed.

[haraken, 2016-03-15 13:12:09]

Looks nicer. LGTM.

[keishi, 2016-03-16 01:28:54]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2016-03-16 01:29:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1804863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1804863002/20001

[commit-bot: I haz the power, 2016-03-16 01:39:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 01:39:47]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[keishi, 2016-03-16 11:40:18]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2016-03-16 11:40:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1804863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1804863002/20001

[commit-bot: I haz the power, 2016-03-16 14:47:09]

Description was changed from

==========
Refactor RegionTree

This creates a new class, RegionTree, so we can reference the binary search tree
and the mutex as one thing.

BUG=591606
==========

to

==========
Refactor RegionTree

This creates a new class, RegionTree, so we can reference the binary search tree
and the mutex as one thing.

BUG=591606
==========

[commit-bot: I haz the power, 2016-03-16 14:47:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-16 14:48:33]

Description was changed from

==========
Refactor RegionTree

This creates a new class, RegionTree, so we can reference the binary search tree
and the mutex as one thing.

BUG=591606
==========

to

==========
Refactor RegionTree

This creates a new class, RegionTree, so we can reference the binary search tree
and the mutex as one thing.

BUG=591606

Committed: https://crrev.com/5227ab950a8d9de588844a3109a16094041c13a8
Cr-Commit-Position: refs/heads/master@{#381451}
==========

[commit-bot: I haz the power, 2016-03-16 14:48:34]

Patchset 2 (id:??) landed as
https://crrev.com/5227ab950a8d9de588844a3109a16094041c13a8
Cr-Commit-Position: refs/heads/master@{#381451}