Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 180483005: Fix PNaCl-local files after merging LLVM 3.4 (Closed)

Created:
6 years, 9 months ago by Mark Seaborn
Modified:
6 years, 8 months ago
CC:
native-client-reviews_googlegroups.com, Karl
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@hs-merge-before-fixes
Visibility:
Public.

Description

Fix PNaCl-local files after merging LLVM 3.4 These are mostly compile fixes: * Update for interface changes: * readBytes() (unused arg was removed) * tool_output_file takes different flags * Materialize() uses error_code instead of bool + string * Remove uses of case ranges, which were removed in 3.4 * pnacl-llc: Some TargetOptions fields were removed in 3.4 Also update test expectations. LLVM's 'not' tool now treats crashes as a failure unless '--crash' is passed. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3757 TEST=PNaCl toolchain trybots Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=fe90708cae889704bba598c5d83eb4d8f38a37c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -55 lines) Patch
M include/llvm/Bitcode/NaCl/NaClBitstreamReader.h View 1 chunk +1 line, -2 lines 0 comments Download
M lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M lib/Bitcode/NaCl/Reader/NaClBitcodeHeader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/Bitcode/NaCl/Reader/NaClBitcodeReader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp View 4 chunks +25 lines, -13 lines 0 comments Download
M lib/Bitcode/NaCl/Writer/NaClBitcodeWriter.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M lib/Target/X86/MCTargetDesc/X86MCNaCl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M lib/Transforms/NaCl/PromoteIntegers.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M test/CodeGen/ARM/varargs-spill-stack-align-nacl.ll View 1 chunk +3 lines, -1 line 0 comments Download
M test/NaCl/PNaClLLC/test-runs-verify.ll View 1 chunk +1 line, -1 line 0 comments Download
M tools/pnacl-bccompress/pnacl-bccompress.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/pnacl-freeze/pnacl-freeze.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/pnacl-llc/ThreadedStreamingCache.h View 1 chunk +1 line, -2 lines 0 comments Download
M tools/pnacl-llc/ThreadedStreamingCache.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M tools/pnacl-llc/pnacl-llc.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M tools/pnacl-thaw/pnacl-thaw.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
6 years, 9 months ago (2014-02-28 21:50:19 UTC) #1
jvoung (off chromium)
lgtm
6 years, 9 months ago (2014-02-28 22:31:48 UTC) #2
jvoung (off chromium)
This CL can be closed now?
6 years, 8 months ago (2014-04-01 23:48:13 UTC) #3
Mark Seaborn
6 years, 8 months ago (2014-04-02 00:35:39 UTC) #4
Message was sent while issue was closed.
On 2014/04/01 23:48:13, jvoung (cr) wrote:
> This CL can be closed now?

Yes.  Committed as:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=co...

Powered by Google App Engine
This is Rietveld 408576698