Issue 180483004: remove SK_SUPPORT_LEGACY_LAYERDRAWLOOPER_PAINTFLAGS -- not needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180483004: remove SK_SUPPORT_LEGACY_LAYERDRAWLOOPER_PAINTFLAGS -- not needed (Closed)

Created:
6 years, 9 months ago by reed1

Modified:
6 years, 9 months ago

Reviewers:
scroggo

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

remove SK_SUPPORT_LEGACY_LAYERDRAWLOOPER_PAINTFLAGS -- not needed BUG=skia: R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=13623

Patch Set 2 : #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -69 lines)			Patch
	M	include/effects/SkLayerDrawLooper.h	View	1	4 chunks	+3 lines, -13 lines	2 comments	Download
	M	src/effects/SkLayerDrawLooper.cpp	View		5 chunks	+6 lines, -56 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scroggo

lgtm https://codereview.chromium.org/180483004/diff/20001/include/effects/SkLayerDrawLooper.h File include/effects/SkLayerDrawLooper.h (right): https://codereview.chromium.org/180483004/diff/20001/include/effects/SkLayerDrawLooper.h#newcode43 include/effects/SkLayerDrawLooper.h:43: * - Color are always computed using the ...

6 years, 9 months ago (2014-02-28 15:00:12 UTC) #2

reed1

https://codereview.chromium.org/180483004/diff/20001/include/effects/SkLayerDrawLooper.h File include/effects/SkLayerDrawLooper.h (right): https://codereview.chromium.org/180483004/diff/20001/include/effects/SkLayerDrawLooper.h#newcode43 include/effects/SkLayerDrawLooper.h:43: * - Color are always computed using the LayerInfo's ...

6 years, 9 months ago (2014-02-28 15:37:53 UTC) #3

reed1

6 years, 9 months ago (2014-02-28 15:38:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r13623 (presubmit successful).

Expand Messages | Collapse Messages

Issue 180483004: remove SK_SUPPORT_LEGACY_LAYERDRAWLOOPER_PAINTFLAGS -- not needed (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages