Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1804813002: Delete ChromeBrowserProviderClient. (Closed)

Created:
4 years, 9 months ago by newt (away)
Modified:
4 years, 9 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete ChromeBrowserProviderClient. It's been superseded by BookmarkBridge and FaviconHelper. This also deletes the code from ChromeBrowserProvider that existed solely to support ChromeBrowserProviderClient. BUG=583477 Committed: https://crrev.com/bb98522277b46d1870196e5334858298ef68f6a9 Cr-Commit-Position: refs/heads/master@{#381163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -793 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/provider/ChromeBrowserProvider.java View 11 chunks +2 lines, -190 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/provider/ChromeBrowserProviderClient.java View 1 chunk +0 lines, -145 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/provider/ProviderTestBase.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 8 chunks +0 lines, -457 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804813002/1
4 years, 9 months ago (2016-03-15 01:08:15 UTC) #2
newt (away)
PTAL :)
4 years, 9 months ago (2016-03-15 01:14:15 UTC) #5
Yaron
On 2016/03/15 01:14:15, newt wrote: > PTAL :) lgtm but I can't wait until the ...
4 years, 9 months ago (2016-03-15 01:41:22 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 02:09:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804813002/1
4 years, 9 months ago (2016-03-15 02:56:12 UTC) #10
newt (away)
On 2016/03/15 01:41:22, Yaron wrote: > On 2016/03/15 01:14:15, newt wrote: > > PTAL :) ...
4 years, 9 months ago (2016-03-15 02:56:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 03:02:17 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 03:03:34 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb98522277b46d1870196e5334858298ef68f6a9
Cr-Commit-Position: refs/heads/master@{#381163}

Powered by Google App Engine
This is Rietveld 408576698