src/parsing/parser.cc - Issue 1804783002: Remove Scope::scope_contains_with_ bit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/parser.cc

Issue 1804783002: Remove Scope::scope_contains_with_ bit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix scope names and GCC build Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/parser.cc

diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc

index dfda89e4db29152526f07f18a59d37375f59173a..d7d8162205ac5f8edf8e3a0f9bd16dc67cb39b0d 100644

--- a/src/parsing/parser.cc

+++ b/src/parsing/parser.cc

@@ -2711,7 +2711,6 @@ Statement* Parser::ParseWithStatement(ZoneList<const AstRawString*>* labels,

Expression* expr = ParseExpression(true, CHECK_OK);

Expect(Token::RPAREN, CHECK_OK);

- scope_->DeclarationScope()->RecordWithStatement();

Scope* with_scope = NewScope(scope_, WITH_SCOPE);

Statement* body;

{ BlockState block_state(&scope_, with_scope);