Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1804743002: Fix generation of getters and fields in quick fixes (issue 25691) (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix generation of getters and fields in quick fixes (issue 25691) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e28c8168551f95e95bdcf583072777b021526fce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-14 21:01:53 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-14 21:03:10 UTC) #3
Brian Wilkerson
4 years, 9 months ago (2016-03-14 21:03:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e28c8168551f95e95bdcf583072777b021526fce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698