pkg/barback/test/package_graph/errors_test.dart - Issue 180473003: Barback transforms now pass through the primary input by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/barback/test/package_graph/errors_test.dart

Issue 180473003: Barback transforms now pass through the primary input by default. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code reivew Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/barback/test/package_graph/add_remove_transform_test.dart ('k') | pkg/barback/test/package_graph/get_all_assets_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/barback/test/package_graph/errors_test.dart

diff --git a/pkg/barback/test/package_graph/errors_test.dart b/pkg/barback/test/package_graph/errors_test.dart

index 8c74991309f451fed7b20cadc0fadbf0d584278a..24281784308c4a28c889add7d8d87d59f2d9f21b 100644

--- a/pkg/barback/test/package_graph/errors_test.dart

+++ b/pkg/barback/test/package_graph/errors_test.dart

@@ -114,15 +114,6 @@ main() {

buildShouldFail([isTransformerException(equals(BadTransformer.ERROR))]);

});

- test("doesn't yield a source if a transform fails on it", () {

- initGraph(["app|foo.txt"], {"app": [

- [new BadTransformer(["app|foo.txt"])]

- ]});

- updateSources(["app|foo.txt"]);

- expectNoAsset("app|foo.txt");

- });

test("catches errors even if nothing is waiting for process results", () {

initGraph(["app|foo.txt"], {"app": [[new BadTransformer([])]]});